GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Center text on timer button by tituscmd · Pull Request #2229 · InfiniTimeOrg/InfiniTime

Conversation

@tituscmd

@tituscmd tituscmd commented Jan 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hey everybody!

This PR is made to center the "Start"/"Pause" text on the button in the timer app. The previous implementation created the text object and aligned it to the button object, this implementation creates the text object with a pointer to the button object and thus makes it centered at all times!

Here's a screenshot of InfiniEmu running it:
Screenshot_2025-01-18_15-29-43

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marigoldfish reacted with thumbs up emoji marigoldfish reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
@tituscmd
centered timer button by connecting text object to button object
b93c2e7
@github-actions

github-actions Bot commented Jan 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 375812B -16B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tituscmd tituscmd changed the title Center timer button correctly Center text on timer button Jan 18, 2025
@tituscmd
centered timer button by connecting text object to button object
6f9caa4
@tituscmd
tituscmd force-pushed the timer_centered branch from b93c2e7 to 6f9caa4 Compare January 21, 2025 13:25
tituscmd added 2 commits January 21, 2025 14:35
@tituscmd
added a space after a comment //
4592e97
@tituscmd
Merge branch 'timer_centered' of github.com:tituscmd/InfiniTime into …
7ea3030 
…timer_centered
@mark9064 mark9064 added enhancement Enhancement to an existing app/feature maintenance Background work labels Jan 23, 2025
tituscmd added 2 commits January 26, 2025 01:09
@tituscmd
centered timer button by connecting text object to button object
3b2b40b
@tituscmd
added a space after a comment //
d033f19
@tituscmd
tituscmd force-pushed the timer_centered branch from 7ea3030 to d033f19 Compare January 26, 2025 00:09
tituscmd added 2 commits January 29, 2025 22:10
@tituscmd
Merge branch 'main' into timer_centered
000f084
@tituscmd
Merge branch 'main' into timer_centered
91aee11
mark9064
mark9064 reviewed Feb 14, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a nicer way to do it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tituscmd reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread src/displayapp/screens/Timer.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mark9064 mark9064 added this to the 1.16.0 milestone Feb 14, 2025
tituscmd added 3 commits February 14, 2025 06:32
@tituscmd
Merge branch 'main' into timer_centered
9afa1aa
@tituscmd
Merge branch 'main' into timer_centered
f236103
@tituscmd
Merge branch 'main' into timer_centered
448bc38
@minacode

minacode commented May 14, 2025

Copy link
Copy Markdown
Contributor

@tituscmd, I think this is ready to merge once you delete the one commented-out line @mark9064 pointed out.

@mark9064, would be fine from my side if you decided to do it yourself. I will approve it either way.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tituscmd

tituscmd commented May 14, 2025

Copy link
Copy Markdown
Contributor Author

@tituscmd, I think this is ready to merge once you delete the one commented-out line @mark9064 pointed out.

@mark9064, would be fine from my side if you decided to do it yourself. I will approve it either way.

I'll be home in about 15 minutes and then I'll do that for sure! 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tituscmd
Merge branch 'main' into timer_centered
b735f01
@tituscmd

tituscmd commented May 14, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@tituscmd, I think this is ready to merge once you delete the one commented-out line @mark9064 pointed out.
@mark9064, would be fine from my side if you decided to do it yourself. I will approve it either way.

I'll be home in about 15 minutes and then I'll do that for sure! 🙂

I guess that 15 minutes was quite the underestimate 😅
Should be all done now!
minacode reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tituscmd added 2 commits May 14, 2025 18:39
@tituscmd
remove old realign line, add command for new label_create line
3b8c07a
@tituscmd
Merge branch 'timer_centered' of github.com:tituscmd/InfiniTime into …
fe6ac14 
…timer_centered
mark9064
mark9064 approved these changes May 14, 2025
View reviewed changes
minacode
minacode approved these changes May 15, 2025
View reviewed changes
@tituscmd
Merge branch 'main' into timer_centered
a068856
JF002
JF002 approved these changes May 16, 2025
View reviewed changes
@minacode
minacode merged commit bb8923b into InfiniTimeOrg:main May 16, 2025
JustScott pushed a commit to JustScott/InfiniTime that referenced this pull request Jul 29, 2025
@tituscmd @JustScott
Center text on timer button (InfiniTimeOrg#2229)
2ac23c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 JF002 approved these changes
@minacode minacode minacode approved these changes
@mark9064 mark9064 mark9064 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement Enhancement to an existing app/feature maintenance Background work

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tituscmd @minacode @JF002 @mark9064
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.