GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — BatteryInfo App Redesign by tituscmd · Pull Request #2236 · InfiniTimeOrg/InfiniTime

Conversation

@tituscmd

@tituscmd tituscmd commented Jan 26, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR is a redesign of the BatteryInfo app.

The colors I used are as follows:
Discharging (default): green
Charging: lime
Battery full: blue
Battery low (<10%): red

Here's a pic of it in InfiniEmu, as well as how each state looks like on-device.
emu
discharging
charging
fully_charged
image
(Can't manage to rescale this image on iOS, I'll get to it later)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mark9064, pipe01, 42Tobias42, liamcharger, Ejioplex, NitroNils, dimembermatt, minacode, Athozus, Saarsk, and TailyFair reacted with rocket emoji
All reactions
  • 🚀 11 reactions
tituscmd and others added 2 commits January 26, 2025 17:59
@tituscmd
redesigned battery app
d77ed84
@tituscmd
Merge branch 'InfiniTimeOrg:main' into battery_app_redesign
c0a9d1a
@github-actions

github-actions Bot commented Jan 26, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 373120B 32B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tituscmd added 3 commits January 26, 2025 18:11
@tituscmd
code cleanup
7cc8ba4
@tituscmd
Merge branch 'battery_app_redesign' of github.com:tituscmd/InfiniTime…
95fae89 
… into battery_app_redesign
@tituscmd
remove unused include
d88f2c0
@mark9064 mark9064 added enhancement Enhancement to an existing app/feature UI/UX User interface/User experience labels Jan 27, 2025
ljahn
ljahn reviewed Jan 27, 2025
View reviewed changes

@ljahn ljahn left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
If one prefers the arc to a bar is personal preference.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/displayapp/screens/BatteryInfo.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
tituscmd and others added 2 commits January 27, 2025 16:11
@tituscmd
fixed centering issue on percent value
23991c5
@tituscmd
Merge branch 'main' into battery_app_redesign
558ecec
@tituscmd

tituscmd commented Feb 8, 2025

Copy link
Copy Markdown
Contributor Author

Would love to see if this could find its way into main 😊
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mark9064
mark9064 reviewed Feb 8, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I prefer this design to the original, but it's totally up to taste. If anyone has a strong opinion against this one I'd be interested to hear it :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tituscmd and minacode reacted with heart emoji
All reactions
  • ❤️ 2 reactions
Comment thread src/displayapp/screens/BatteryInfo.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/displayapp/screens/BatteryInfo.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tituscmd
renamed charging_arc to chargingArc and readded the 'batteryVoltage =…
c92dd35 
… [...]' line in the Refresh() method
mark9064
mark9064 approved these changes Feb 9, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll queue it for 1.16 but let's leave some time before merging for other feedback

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tituscmd reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@mark9064 mark9064 added this to the 1.16.0 milestone Feb 9, 2025
@tituscmd

tituscmd commented Feb 9, 2025

Copy link
Copy Markdown
Contributor Author

LGTM! I'll queue it for 1.16 but let's leave some time before merging for other feedback

Great! Sounds like a good plan to me 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tituscmd

tituscmd commented Feb 9, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

grafik
My PC's timezone is off so GitHub is showing me stuff that hasn't happened yet 😳😄
mark9064 and marigoldfish reacted with eyes emoji
All reactions
  • 👀 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tituscmd added 2 commits February 11, 2025 10:51
@tituscmd
Merge branch 'main' into battery_app_redesign
c1cd9ab
@tituscmd
Merge branch 'main' into battery_app_redesign
aa16926
NeroBurner
NeroBurner approved these changes Mar 14, 2025
View reviewed changes

@NeroBurner NeroBurner left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, UI as well

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tituscmd reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@tituscmd
Merge branch 'main' into battery_app_redesign
159c4ba
@NeroBurner
NeroBurner merged commit 30e5683 into InfiniTimeOrg:main Mar 14, 2025
@tituscmd tituscmd mentioned this pull request Jun 10, 2025
BatteryInfo App Redesign: Fixup #2310
Merged
JustScott pushed a commit to JustScott/InfiniTime that referenced this pull request Jul 29, 2025
@tituscmd @JustScott
BatteryInfo App Redesign using arc (InfiniTimeOrg#2236)
36f8861 
Redesign BatteryInfo App using an Arch widget instead of a bar.

The colors I used are as follows:
- Discharging (default): green
- Charging: lime
- Battery full: blue
- Battery low (<10%): red
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NeroBurner NeroBurner NeroBurner approved these changes
@mark9064 mark9064 mark9064 approved these changes
+1 more reviewer
@ljahn ljahn ljahn left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement Enhancement to an existing app/feature UI/UX User interface/User experience

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tituscmd @NeroBurner @mark9064 @ljahn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.