GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — Add background color to progress bar when flashing firmware by tituscmd · Pull Request #2237 · InfiniTimeOrg/InfiniTime Conversation
Contributor
This PR adds a background color to the progress bar when updating firmware. Here's a pic of how it looks like on device:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Build size and comparison to main:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested on HW, but looks good from the screenshot :)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Just a note about the space between the value and percentage sign. A space there is the correct way of writing it. 🙂 I think it should be formatted the correct way. I can understand that sometimes it happens that the correct way doesn't feel right. We tend to expect what we're conditioned to. I've had the same experience. Though, it's just a matter of getting used to it, i.e. reconditioning. So rather than doing what subjectively feels right I think there's value to following objectively correct and commonly agreed conventions. 🙂 A lack there of will have negative effects regardless whether it's in a software project or in a book, as we adopt by reading and using language. So whenever something is incorrect, it spreads. Other than that, I very much welcome the progress bar improvement. 😊 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
"However, the International System of Units and ISO 31-0 standard prescribe a space between the number and percent sign,[8][9][10] in line with the general practice of using a non-breaking space between a numerical value and its corresponding unit of measurement." Let's go for this then, shall we? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I think without the space is better. Wikipedia is quite clear: InfiniTime is not a technical document, but instead a user interface. Therefore I think following general English style and precedent makes sense. If it were a technical report then I would agree that recognising a standard such as ISO would be sensible (and if I were typsetting with LateX I would by using |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Can't test it right now but would approve it from reading the code and seeing the images. Tell me if you would be ok with this, then I can accept it as well. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I think from my side this PR should be done as well. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.