GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add background color to progress bar when flashing firmware by tituscmd · Pull Request #2237 · InfiniTimeOrg/InfiniTime

Conversation

@tituscmd

@tituscmd tituscmd commented Jan 27, 2025

Copy link
Copy Markdown
Contributor

This PR adds a background color to the progress bar when updating firmware.
It also removes the space between the value and the "%", since I feel like that's more commonly used and, in my opinion, looks better. Feel free to give your opinion on that, though!

Here's a pic of how it looks like on device:
(Hint: To see it in action, you’ll first need to flash the firmware. Then, flash any other firmware, as the firmware update screen is displayed by the firmware currently on the device.)
progress_bar

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

NitroNils reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
tituscmd and others added 3 commits January 21, 2025 13:50
@tituscmd
Merge pull request #26 from InfiniTimeOrg/main
c73f016
Alarm: Simplify alarm alerting screen (InfiniTimeOrg#2211)
@tituscmd
added bg color to progess bar; removed space between value and %-symbol
53c0b74
@tituscmd
Merge branch 'main' into firmware_update_progress_bar
e3319ac
@github-actions

github-actions Bot commented Jan 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 375828B 48B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tituscmd
Merge branch 'main' into firmware_update_progress_bar
33bf765
@mark9064 mark9064 added enhancement Enhancement to an existing app/feature UI/UX User interface/User experience labels Feb 7, 2025
@tituscmd
Merge branch 'main' into firmware_update_progress_bar
fb43444
mark9064
mark9064 approved these changes Feb 14, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested on HW, but looks good from the screenshot :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tituscmd reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@mark9064 mark9064 added this to the 1.16.0 milestone Feb 14, 2025
tituscmd added 2 commits February 14, 2025 06:32
@tituscmd
Merge branch 'main' into firmware_update_progress_bar
b089fc3
@tituscmd
Merge branch 'main' into firmware_update_progress_bar
8e4c4f6
@Saarsk

Saarsk commented Mar 27, 2025

Copy link
Copy Markdown

Just a note about the space between the value and percentage sign. A space there is the correct way of writing it. 🙂 I think it should be formatted the correct way.

I can understand that sometimes it happens that the correct way doesn't feel right. We tend to expect what we're conditioned to. I've had the same experience.

Though, it's just a matter of getting used to it, i.e. reconditioning. So rather than doing what subjectively feels right I think there's value to following objectively correct and commonly agreed conventions. 🙂 A lack there of will have negative effects regardless whether it's in a software project or in a book, as we adopt by reading and using language. So whenever something is incorrect, it spreads.

Other than that, I very much welcome the progress bar improvement. 😊

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tituscmd

tituscmd commented Mar 27, 2025

Copy link
Copy Markdown
Contributor Author

"However, the International System of Units and ISO 31-0 standard prescribe a space between the number and percent sign,[8][9][10] in line with the general practice of using a non-breaking space between a numerical value and its corresponding unit of measurement."

Let's go for this then, shall we?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mark9064

mark9064 commented Mar 27, 2025

Copy link
Copy Markdown
Member

I think without the space is better. Wikipedia is quite clear: English style guides prescribe writing the percent sign following the number without any space between (e.g. 50%)

InfiniTime is not a technical document, but instead a user interface. Therefore I think following general English style and precedent makes sense. If it were a technical report then I would agree that recognising a standard such as ISO would be sensible (and if I were typsetting with LateX I would by using siunitx), and the same may apply in another language (it appears that some languages expect a space by default)

tituscmd and minacode reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tituscmd
Merge branch 'main' into firmware_update_progress_bar
2e2b1a5
@minacode

minacode commented May 14, 2025

Copy link
Copy Markdown
Contributor

Can't test it right now but would approve it from reading the code and seeing the images. Tell me if you would be ok with this, then I can accept it as well.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tituscmd
Merge branch 'main' into firmware_update_progress_bar
723f20c
@tituscmd

tituscmd commented May 14, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I think from my side this PR should be done as well.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mark9064
mark9064 approved these changes May 14, 2025
View reviewed changes
minacode
minacode approved these changes May 15, 2025
View reviewed changes
@mark9064
mark9064 merged commit 85be83b into InfiniTimeOrg:main May 15, 2025
JustScott pushed a commit to JustScott/InfiniTime that referenced this pull request Jul 29, 2025
@tituscmd @JustScott
Add background color to progress bar when flashing firmware (InfiniTi…
6871336
…meOrg#2237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minacode minacode minacode approved these changes
@mark9064 mark9064 mark9064 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement Enhancement to an existing app/feature UI/UX User interface/User experience

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tituscmd @Saarsk @mark9064 @minacode
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.