GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — navigation: fix greying out the app icon if not enabled by mmind · Pull Request #2301 · InfiniTimeOrg/InfiniTime

Conversation

@mmind

@mmind mmind commented May 26, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Commit 0aead42 ("navigation: Add is available (#1847)") added the ability to draw the app icon in grey and in a disabled state when some prerequisits were not met. Only the Navigation app was using this mechanism due to its icons being stored in the external memory and possibly missing.

Commit 63e0c4f ("Application selection at build time") broke this by always setting the state as true:
for (const auto& userApp : userApps) {
apps[i++] = Screens::Tile::Applications {userApp.icon, userApp.app, true};
}

Fix this by creating an isAvailable() strcuture in the app classes, similar
to how the Watchfaces handle the same problem of checking availability.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mark9064 mark9064 added bug Something isn't working UI/UX User interface/User experience labels May 26, 2025
@mmind mmind mentioned this pull request May 27, 2025
Dark App Launcher Tiles #2294
Merged
@github-actions

github-actions Bot commented May 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 379204B 224B
data 944B 0B
bss 22536B 0B

Run in InfiniEmu
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mmind
mmind force-pushed the navigation-check-disable branch 3 times, most recently from 08abd5e to f2f5ec3 Compare May 29, 2025 20:36
@mmind mmind mentioned this pull request May 29, 2025
Navigation style updates #2303
Open
@NeroBurner NeroBurner added this to the 1.16.0 milestone May 29, 2025
@NeroBurner

NeroBurner commented May 30, 2025

Copy link
Copy Markdown
Contributor

Fixing it for just one App feels wrong for me. Would you be interested in implementing the same behavior as done with the Watchfaces?

Having a default isAvailable function returning true, and override it for Apps that need it. In our case just Navigation
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mmind

mmind commented Jun 1, 2025

Copy link
Copy Markdown
Author

@NeroBurner sure, I can do that :-) .

I stumbled upon that thing while doing the other navigation stuff and InfiniSim not showing the flags, but also did not have a grasp on how the whole thing works.

So you're definitly right, doing that only for Navigation does not scale :-) and also thanks for pointing out how things should look correctly.
NeroBurner reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mmind
mmind force-pushed the navigation-check-disable branch from f2f5ec3 to 915a9bd Compare June 1, 2025 19:39
@mmind

mmind commented Jun 1, 2025

Copy link
Copy Markdown
Author

Hopefully that is what you had in mind :-) ... Follows now how the Wachfaces look
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
NeroBurner
NeroBurner approved these changes Jun 16, 2025
View reviewed changes

@NeroBurner NeroBurner left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you got it right. Good job!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mark9064
mark9064 approved these changes Jun 16, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/displayapp/screens/Navigation.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mmind
mmind force-pushed the navigation-check-disable branch from 915a9bd to 7e0b63a Compare July 2, 2025 07:41
Heiko Stuebner
navigation: fix greying out the app icon if not enabled
b6c20f6 
Commit 0aead42 ("navigation: Add is available (InfiniTimeOrg#1847)") added the
ability to draw the app icon in grey and in a disabled state when some
prerequisits were not met. Only the Navigation app was using this mechanism
due to its icons being stored in the external memory and possibly missing.

Commit 63e0c4f ("Application selection at build time") broke this by
always setting the state as true:
      for (const auto& userApp : userApps) {
        apps[i++] = Screens::Tile::Applications {userApp.icon, userApp.app, true};
      }

Fix this by creating an isAvailable() strcuture in the app classes, similar
to how the Watchfaces handle the same problem of checking availability.
@mmind
mmind force-pushed the navigation-check-disable branch from 7e0b63a to b6c20f6 Compare July 2, 2025 09:51
@mark9064
mark9064 merged commit 9afc23c into InfiniTimeOrg:main Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark9064 mark9064 mark9064 approved these changes
@NeroBurner NeroBurner NeroBurner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug Something isn't working UI/UX User interface/User experience

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mmind @NeroBurner @mark9064
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.