GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||
GeezerVison is showing github.com — Dark App Launcher Tiles by tituscmd · Pull Request #2294 · InfiniTimeOrg/InfiniTime Conversation
Contributor
This is a simple PR to replace the aqua colored tiles in the app launcher with darker ones, going hand-in-hand with my #2292 Let me know what you think!
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Alarm: Simplify alarm alerting screen (InfiniTimeOrg#2211)
|
There was an error while loading. Please reload this page.
|
Build size and comparison to main:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The issue I see with this is it's a matter of preference: some people may prefer the aqua, and some may prefer this gray. I'm not sure if this would align with the vision, but a setting to change the theme would be nice, with options for the original color, this gray, maybe a red, and so on. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I think we'd probably want to stick to one theme, as supporting multiple adds some extra overhead from a code maintenance perspective. I think it's nice that the colours are synchronised, though I don't feel super strongly |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
As I found out in #2301 , the application launcher does track an enabled state for the app icons (for when the resources are missing for example). So nothing against changing the color, just mentioning that is should probably still allow seeing a disabled app icon. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@JF002 Any chance you can chime in, I got interested in InfiniTime long after this colour was chosen so wondering if there's any history here (and therefore maybe reasons to change/not to change it) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm not sure I remember how this specific color was chosen, to be honest. We used to have maintainers who took care of the UI (themes, colors, layout,..) but they are not around anymore. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
All LGTM to me then :)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I agree that using the theme here is the correct way to go. Changing the theme would be another discussion. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you! 🙂 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
You're very welcome! :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.