GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Dark App Launcher Tiles by tituscmd · Pull Request #2294 · InfiniTimeOrg/InfiniTime

Conversation

@tituscmd

@tituscmd tituscmd commented May 12, 2025

Copy link
Copy Markdown
Contributor

This is a simple PR to replace the aqua colored tiles in the app launcher with darker ones, going hand-in-hand with my #2292
This is most likely just up to taste, but I thought the cyan tiles were outdated since that color isn't used anywhere else, so I thought a darker color would match the current system theme better.

Let me know what you think!

image
image
image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pipe01 and minacode reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
tituscmd and others added 3 commits January 21, 2025 13:50
@tituscmd
Merge pull request #26 from InfiniTimeOrg/main
c73f016
Alarm: Simplify alarm alerting screen (InfiniTimeOrg#2211)
@tituscmd
Merge branch 'InfiniTimeOrg:main' into main
ec4b3a7
@tituscmd
changed tile color from aqua do bgAlt
b70e47a
@tituscmd tituscmd changed the title Dark tiles Dark App Launcher Tiles May 12, 2025
@tituscmd
formatting
731bc87
@github-actions

github-actions Bot commented May 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 378980B -16B
data 944B 0B
bss 22536B 0B

Run in InfiniEmu

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@liamcharger

liamcharger commented May 12, 2025

Copy link
Copy Markdown
Contributor

The issue I see with this is it's a matter of preference: some people may prefer the aqua, and some may prefer this gray.

I'm not sure if this would align with the vision, but a setting to change the theme would be nice, with options for the original color, this gray, maybe a red, and so on.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mark9064

mark9064 commented May 12, 2025

Copy link
Copy Markdown
Member

I think we'd probably want to stick to one theme, as supporting multiple adds some extra overhead from a code maintenance perspective.

I think it's nice that the colours are synchronised, though I don't feel super strongly

minacode reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mark9064
mark9064 reviewed May 12, 2025
View reviewed changes
Comment thread src/displayapp/screens/Tile.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mark9064 mark9064 added the UI/UX User interface/User experience label May 12, 2025
@tituscmd
Merge branch 'main' into dark_tiles
08fd0d9
@mark9064 mark9064 mentioned this pull request May 16, 2025
(small) Music App Redesign #2292
Merged
@mmind

mmind commented May 27, 2025

Copy link
Copy Markdown

As I found out in #2301 , the application launcher does track an enabled state for the app icons (for when the resources are missing for example).

So nothing against changing the color, just mentioning that is should probably still allow seeing a disabled app icon.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tituscmd and others added 2 commits May 30, 2025 15:45
@tituscmd
remove unnessecary comment
12fd9d1
@tituscmd
Merge branch 'main' into dark_tiles
c14b42a
@mark9064

mark9064 commented May 30, 2025

Copy link
Copy Markdown
Member

@JF002 Any chance you can chime in, I got interested in InfiniTime long after this colour was chosen so wondering if there's any history here (and therefore maybe reasons to change/not to change it)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JF002

JF002 commented May 31, 2025

Copy link
Copy Markdown
Collaborator

I'm not sure I remember how this specific color was chosen, to be honest. We used to have maintainers who took care of the UI (themes, colors, layout,..) but they are not around anymore.
I think there's no reason not to change it, especially if it improves the user experience and consistency between all InfiniTime applications.

tituscmd reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tituscmd
Merge branch 'main' into dark_tiles
51862b7
mark9064
mark9064 approved these changes Jun 1, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM to me then :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tituscmd
Merge branch 'main' into dark_tiles
1e9f830
@mark9064 mark9064 added this to the 1.16.0 milestone Jun 17, 2025
@tituscmd
Merge branch 'main' into dark_tiles
08d5754
@minacode

minacode commented Jun 29, 2025

Copy link
Copy Markdown
Contributor

I agree that using the theme here is the correct way to go. Changing the theme would be another discussion.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

minacode
minacode approved these changes Jun 29, 2025
View reviewed changes
@minacode
Merge branch 'main' into dark_tiles
27f1dac
@minacode
minacode merged commit 250e7a7 into InfiniTimeOrg:main Jun 29, 2025
@minacode

minacode commented Jun 29, 2025

Copy link
Copy Markdown
Contributor

Thank you! 🙂

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tituscmd

tituscmd commented Jun 29, 2025

Copy link
Copy Markdown
Contributor Author

Thank you! 🙂

You're very welcome! :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JustScott pushed a commit to JustScott/InfiniTime that referenced this pull request Jul 29, 2025
@tituscmd @JustScott
Dark App Launcher Tiles (InfiniTimeOrg#2294)
fe0a8c8
tmaklin pushed a commit to tmaklin/InfiniTime that referenced this pull request Jul 31, 2025
@tituscmd @tmaklin
Dark App Launcher Tiles (InfiniTimeOrg#2294)
088b818
metaphys pushed a commit to metaphys/InfiniTime that referenced this pull request Mar 30, 2026
@tituscmd @metaphys
Dark App Launcher Tiles (InfiniTimeOrg#2294)
b4d132e
iakat pushed a commit to iakat/InfiniTime that referenced this pull request Jun 8, 2026
@tituscmd @iakat
Dark App Launcher Tiles (InfiniTimeOrg#2294)
0a79028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minacode minacode minacode approved these changes
@mark9064 mark9064 mark9064 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

UI/UX User interface/User experience

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@tituscmd @liamcharger @mark9064 @mmind @JF002 @minacode
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.