GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — Normalize line endings of text files in the repository (#304) by BCSharp · Pull Request #531 · IronLanguages/ironpython3 Conversation
|
|
My only hangup on this is the file from the stdlib. If the file matches the line endings in the C Python repo, then we need to maintain the file as is. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@slide I checked locally and coding20731.py is CRLF when installing on Windows so it should be fine. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hmm, nvm my last comment, in the CPython repo it's always CRLF. Looking at their .gitattributes: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Indeed. But in this case I think we should take over all of those .gitignore specs and make sure all affected files are checked in exactly in the same way as in CPython, do you agree? Otherwise, we may have a situation that some tests (enabled in the future) pass on one platform but fail on another. Which version of CPython does the StdLib come from? On a side note, I see that CPython declares *.ps1 files as always CRLF; IronPython had makefile.ps1 as always LF. I have made .ps1 files auto, which makes more sense in times of portable PowerShell. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I agree, we should probably add |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
They added those .gitatributes fairly recently, in 3.7 and then backported all the way to 3.5 and 2.7. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I think something the following would do the trick: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I took over those for .sln, .proj as well (although there are no such files in this location), just to prevent any surprises in the future. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for the PR! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.