GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — mark various test data binary by benjaminp · Pull Request #233 · python/cpython

Conversation

@benjaminp

@benjaminp benjaminp commented Feb 22, 2017

Copy link
Copy Markdown
Contributor

It seems git's automatic LF -> CRLF translation for some binary data files is breaking the Windows buildbots. (My favorite is ModuleNotFoundError: No module named 'random\r'.) Turn that off .

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benjaminp
mark various test data binary
0e7561d
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 22, 2017
methane
methane approved these changes Feb 22, 2017
View reviewed changes
@serhiy-storchaka

serhiy-storchaka commented Feb 22, 2017

Copy link
Copy Markdown
Member

What about other binary data?

Lib/test/audiodata/*
Lib/test/imghdrdata/*
Lib/test/audiotest.au
Lib/test/Sine-1000Hz-300ms.aif
*.tar
*.zip
Lib/idlelib/Icons/*

and others.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag berkerpeksag added needs backport to 2.7 labels Feb 22, 2017
@benjaminp

benjaminp commented Feb 23, 2017

Copy link
Copy Markdown
Contributor Author

We can add those, too, but git seems to at least automatically recognize them as binary.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjaminp
benjaminp merged commit 2771304 into master Feb 23, 2017
@benjaminp
benjaminp deleted the benjamin-binary-test-data branch February 23, 2017 06:38
benjaminp added a commit that referenced this pull request Feb 26, 2017
@benjaminp
mark various test data binary (#233)
4c0e028
benjaminp added a commit that referenced this pull request Feb 26, 2017
@benjaminp
mark various test data binary (#233) (#303)
6e9e649
benjaminp added a commit that referenced this pull request Feb 26, 2017
@benjaminp
mark various test data binary (#233)
2334587
benjaminp added a commit that referenced this pull request Feb 26, 2017
@benjaminp
mark various test data binary (#233) (#304)
91c499f
@Mariatta Mariatta removed needs backport to 2.7 labels Mar 6, 2017
@Mariatta Mariatta removed the needs backport to 3.5 label Apr 9, 2017
@BCSharp BCSharp mentioned this pull request Feb 4, 2019
Normalize line endings of text files in the repository (#304) IronLanguages/ironpython3#531
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@benjaminp @serhiy-storchaka @methane @berkerpeksag @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.