Description

gitmotte

opened on Jul 23, 2022

Issue body actions

#1527 introduced DELETE with RETURNING and used Feature.insertReturningExpressionList
within the validation net.sf.jsqlparser.util.validation.validator.DeleteValidator - the Feature.insertReturningExpressionList is part of the validation group FeaturesAllowed.INSERT and therefore only allowed for INSERT statements.

The bugfix fixes the problem with a new feature constant Feature.deleteReturningExpressionList which is part of the validation group FeaturesAllowed.DELETE.

Activity

1. gitmotte

   added 2 commits that reference this issue on Jul 23, 2022

   Using own Feature - constant for "delete with returning" JSQLParser#1597

   9cdff4f

   Using own Feature - constant for "delete with returning" JSQLParser#1597

   7933899
2. manticore-projects commented on Jul 23, 2022

   

   manticore-projects

   on Jul 23, 2022

   Contributor

   More actions

   Thank you for helping me out! I honestly have no idea how this validation framework works and tried brute force.
3. gitmotte commented on Jul 23, 2022

   

   gitmotte

   on Jul 23, 2022

   ContributorAuthor

   More actions

   Are the correlations clearer for you now, when you look at the changes?
4. gitmotte commented on Jul 23, 2022

   

   gitmotte

   on Jul 23, 2022

   ContributorAuthor

   More actions

   I've added a "Further development" section to the wiki of my fork - could you please merge it to the original wiki of JSQLParser @wumpz ?

   https://github.com/gitmotte/JSqlParser/wiki/Examples-of-SQL-Validation#further-development

   (don't know how to add merge requests for wiki-pages)
5. wumpz

   added a commit that references this issue on Jul 25, 2022

   Using own Feature - constant for "delete with returning" #1597 (#1598)

   d321848
6. wumpz commented on Jul 26, 2022

   

   wumpz

   on Jul 26, 2022

   Member

   More actions

   merged it :) manually

   Reacted by gitmotte

   Reacted by gitmotte
7. wumpz

   closed this as completedon Jul 26, 2022

Issue actions