GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow isolation keywords as column name and aliases by tomershay · Pull Request #1534 · JSQLParser/JSqlParser

Conversation

@tomershay

@tomershay tomershay commented May 10, 2022

Copy link
Copy Markdown
Contributor

This allows to parse statements such as:
SELECT col FROM tbl cs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tomershay
Allow isolation keywords as column name and aliases
8d5b529
wumpz
wumpz requested changes May 11, 2022
View reviewed changes
Comment thread src/test/java/net/sf/jsqlparser/statement/select/SelectTest.java

@Test
public void selectIsolationKeywordsAsAlias() throws JSQLParserException {
String stmt = "SELECT col FROM tbl cs";

@wumpz wumpz May 11, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not test your isolation usage.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tomershay tomershay May 17, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other tests already testing isolation usage (for example, testWithIsolation).
This PR just allows "cs" to be used as a column name / alias, as otherwise parsing fails when it's used.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wumpz
wumpz merged commit fc5a9a3 into JSQLParser:master May 19, 2022
@Fudeveloper Fudeveloper mentioned this pull request Feb 17, 2023
[bug] 不支持使用cs、ur、uu等隔离级别的关键字 baomidou/mybatis-plus#5142
Closed
manfredma pushed a commit to manfredma/exercises that referenced this pull request Jun 17, 2024
maxingfang
jsqlparser44 解决隔离问题时存在bug
6fbccaa 
JSQLParser/JSqlParser#1534
manfredma pushed a commit to manfredma/exercises that referenced this pull request Jul 8, 2024
maxingfang
jsqlparser44 解决隔离问题时存在bug
67c362d 
JSQLParser/JSqlParser#1534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wumpz wumpz wumpz requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tomershay @wumpz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.