GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add module info by bowbahdoe · Pull Request #1998 · JSQLParser/JSqlParser

Conversation

@bowbahdoe

@bowbahdoe bowbahdoe commented Apr 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds an explicit module descriptor. This allows downstream consumers to use jlink.

I'm currently "working through" everything that is a transitive dependency of spring with the hope of eventually making spring be fully modularized

https://spring-modularization.netlify.app/

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adanski reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
bowbahdoe added 2 commits April 30, 2024 00:33
@bowbahdoe
Add module info
915f056
@bowbahdoe
Trailing newline
4966fd5
@manticore-projects
manticore-projects merged commit 761b45b into JSQLParser:master Apr 30, 2024
@manticore-projects

manticore-projects commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution, much appreciated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bowbahdoe

bowbahdoe commented Apr 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

You merged really quickly. This is missing a requires java.sql;
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

Please just add.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bowbahdoe bowbahdoe mentioned this pull request Apr 30, 2024
Add missing java.sql require #1999
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bowbahdoe @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.