GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add missing java.sql require by bowbahdoe · Pull Request #1999 · JSQLParser/JSqlParser

Conversation

@bowbahdoe

@bowbahdoe bowbahdoe commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

Follow up to #1998

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adanski reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
bowbahdoe added 5 commits April 30, 2024 00:44
@bowbahdoe
Add missing java.sql
3528d8b
@bowbahdoe
Update maven checkstyle
35f3e84
@bowbahdoe
Fix gradle checkstyle
d07ad82
@bowbahdoe
Bump surefire plugin
8b4820b
@bowbahdoe
Skip modules in tests
e5263cc
@manticore-projects
manticore-projects merged commit df48c4b into JSQLParser:master Apr 30, 2024
@manticore-projects

manticore-projects commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

Now the JavaDoc fails?
Can you please execute locally

gradle publishToMavenLocal

and make this run?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@manticore-projects

manticore-projects commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

Maven also throws errors now

[ERROR] Errors: 
[ERROR]   DeclareStatementTest.testDeclareTable:98 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57
[ERROR]   DeclareStatementTest.testDeclareType:43 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57
[ERROR]   DeclareStatementTest.testDeclareTypeList:72 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57
[ERROR]   DeclareStatementTest.testDeclareTypeWithDefault:56 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57
[ERROR]   AlterTest.testAlterOnlyIssue928:577 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57
[ERROR]   AlterTest.testAlterTableCheckConstraint:280 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57
[ERROR]   AlterTest.testAlterTableColumnCommentIssue984:645 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57
[ERROR]   AlterTest.testAlterTableTableCommentIssue984:632 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57
[ERROR]   AlterSequenceTest.testCreateSequence_withIncrement:33 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57
[INFO] 
[ERROR] Tests run: 3129, Failures: 0, Errors: 9, Skipped: 20
[INFO] 
[WARNING] Corrupted channel by directly writing to native stream in forked JVM 1. See FAQ web page and the dump file /home/are/Documents/src/JSQLFormatter/JSQLParser/target/surefire-reports/2024-04-30T12-16-58_973-jvmRun1.dumpstream
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bowbahdoe

bowbahdoe commented Apr 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@manticore-projects I checked out the commit before i did anything. the maven tests still fail. They are just broken on newer java versions. Same deal with gradle publishToMavenLocal and javadoc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@manticore-projects

manticore-projects commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

No worries, I got that fixed in the latest commit.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bowbahdoe bowbahdoe mentioned this pull request Apr 30, 2024
Declare Spring modules with JDK 9 module metadata [SPR-13501] spring-projects/spring-framework#18079
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bowbahdoe @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.