GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: add support for quoted alias by eortiz-tracktik · Pull Request #33 · JavaScriptor/js-sql-parser

Conversation

@eortiz-tracktik

@eortiz-tracktik eortiz-tracktik commented Mar 26, 2020

Copy link
Copy Markdown
Contributor

We are using this parser and we would like to be able to use quoted alias like on the tests.
Basically, anything quoted should be safe as a quoted identifier?

Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@eortiz-tracktik
feat: add support for quoted alias
d3c4871
@albin3

albin3 commented Mar 27, 2020

Copy link
Copy Markdown
Member

@eortiz-tracktik It's an identifier in code.

https://github.com/JavaScriptor/js-sql-parser/blob/master/src/sqlParser.jison#L14

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@eortiz-tracktik

eortiz-tracktik commented Mar 27, 2020

Copy link
Copy Markdown
Contributor Author

@albin3 thanks for the quick response.
We have tried to use it, but is limited to some specific characters and we can't use some of the special characters we have put on the tests.

  it('support quoted alias', function() {
    testParser('select a as `A-A` from b limit 2;');
    testParser('select a as `A#A` from b limit 2;');
    testParser('select a as `A?A` from b limit 2;');
    testParser('select a as `A/B` from b limit 2;');
    testParser('select a as `A.A` from b limit 2;');
    testParser('select a as `A|A` from b limit 2;');
    testParser('select a as `A A` from b limit 2;');
  });

I saw that there was already the concept of QUOTED_IDENTIFIER but was also limited to certain characters.
I understand why we need to limit the allowed characters on regular identifiers, but if it's quoted I think we don't need to have this restriction.

albin3 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@albin3
albin3 merged commit bb66951 into JavaScriptor:master Mar 30, 2020
@albin3

albin3 commented Mar 30, 2020

Copy link
Copy Markdown
Member

@eortiz-tracktik you are right! thanks for this pr. 😺

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@albin3

albin3 commented Mar 30, 2020

Copy link
Copy Markdown
Member

v1.2.2 has released.

eortiz-tracktik reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@eortiz-tracktik

eortiz-tracktik commented Mar 30, 2020

Copy link
Copy Markdown
Contributor Author

Thanks a lot to you @albin3 for this awesome project! 👏

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@billreynolds007 billreynolds007 mentioned this pull request Sep 13, 2020
identifier double quoting support #44
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@eortiz-tracktik @albin3
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.