GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Discourage installation for ST4 users by FichteFoll · Pull Request #255 · MagicStack/MagicPython

Conversation

@FichteFoll

@FichteFoll FichteFoll commented Feb 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The package is behind the default Python syntax in adopting new syntax features and in adhering to the scoping standards that the community has established for the default packages. It also has access to branching and can thus reliably detect whether a curly brace begins a set or a dict literal over multiple lines.
Besides, the latest update installable via Package Control has been released over 4 years ago because no tag has been pushed to the repo since and that is required for Package Control to pick up new versions.

2023-02-23_20-41-54

Thus, I propose to discourage installation for ST4 users. Users of older versions may still want to install it because their default packages won't receive any updates anymore. You should also push a new tag to the repo to allow installation of the latest changes for ST users of older versions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
keith-hall, LDAP, michaelblyons, espdev, and chris-vecchio reacted with thumbs up emoji
All reactions
  • 👍 5 reactions
@FichteFoll
Discourage installation for ST4 users
272dace
@FichteFoll

FichteFoll commented Feb 23, 2023

Copy link
Copy Markdown
Author

It would probably also be a good idea to outright disable installation of MagicPython for ST4 users altogether. I can quickly make that change if you agree to it, but I want to confirm this with you first as there may still be some reason that users would want to use MagicPython over the default that I don't know about.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FichteFoll

FichteFoll commented Oct 27, 2023

Copy link
Copy Markdown
Author

Bump.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
FichteFoll added a commit to sublimehq/package_control_channel that referenced this pull request Oct 29, 2023
@FichteFoll
Prevent installation of MagicPython on ST4
78a93a9 
There is very little reason to do this when the default syntax
definition is much better due to using the `sublime-syntax` format,
follows the scope naming standards and is actively maintained, because
this package hasn't had a tag pushed in 4 years despite seeing *some*
changes, albeit the last one over a year ago.

A pull request asking for clarification of the support status for ST4
has not been answered for 8 months.
MagicStack/MagicPython#255
@FichteFoll FichteFoll mentioned this pull request Oct 29, 2023
Prevent installation of MagicPython on ST4 sublimehq/package_control_channel#8841
Merged
@FichteFoll

FichteFoll commented Oct 29, 2023

Copy link
Copy Markdown
Author

It would probably also be a good idea to outright disable installation of MagicPython for ST4 users altogether.

I've gone ahead and did that. We will probably merge it soon, although it can easily be reverted. However, I currently don't see any reason for it.

sublimehq/package_control_channel#8841
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@FichteFoll
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.