GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Static Type-checking for httptools by Vizonex · Pull Request #100 · MagicStack/httptools

Conversation

@Vizonex

@Vizonex Vizonex commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

I felt the need to add static type-checking to this library in order to help other programmers with using this library. I hope this pull request will help out a few people with using this library.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DABND19 reacted with thumbs up emoji ckcollab reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction
Vizonex added 4 commits June 28, 2024 17:02
@Vizonex
Add static protocol object for type checking
d1d9d9e
@Vizonex
Create url_parser.pyi
02e8f3d
@Vizonex
Create parser.pyi
6011b57
@Vizonex
add protocol module
a248458
DABND19
DABND19 reviewed Jul 17, 2024
View reviewed changes
Comment thread httptools/parser/url_parser.pyi Outdated
fragment:bytes
userinfo:bytes

def parse_url(url:Union[bytes, bytearray, memoryview, array]) -> URL:

@DABND19 DABND19 Jul 17, 2024

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add spaces after colons for type annotations

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Vizonex

Vizonex commented Jul 17, 2024 via email

Copy link
Copy Markdown
Contributor Author
On Wed, Jul 17, 2024 at 5:11 AM David Grigorenko ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In httptools/parser/url_parser.pyi <#100 (comment)>: > @@ -0,0 +1,29 @@ +from typing import Union +from array import array + +class URL: + schema:bytes + host:bytes + port:int + path:bytes + query:bytes + fragment:bytes + userinfo:bytes + +def parse_url(url:Union[bytes, bytearray, memoryview, array]) -> URL: I think you should add spaces after colons for type annotations — Reply to this email directly, view it on GitHub <#100 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3K7GGVIXG426I4JPGQSNXDZMY7MVAVCNFSM6AAAAABKCSKGNSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBSGQ4TAMBXGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>
Thanks for your input I will make sure that I add that in.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
KRRT7 added 2 commits October 15, 2024 11:03
@KRRT7
Merge branch 'master' of https://github.com/MagicStack/httptools
b2a3833
@KRRT7
add spacing and semi black formatting
01308ee
@KRRT7 KRRT7 mentioned this pull request Oct 15, 2024
unblock upstream PR Vizonex/httptools#1
Merged
@Vizonex
Merge pull request #1 from KRRT7/master
459ead9 
unblock upstream PR
@KRRT7

KRRT7 commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

@DABND19 could you take a look? thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DABND19

DABND19 commented Dec 6, 2024

Copy link
Copy Markdown

@DABND19 could you take a look? thanks

Hi! I am not the maintainer of this repository, I just left my comments on this pull request :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Vizonex

Vizonex commented Dec 8, 2024

Copy link
Copy Markdown
Contributor Author

thanks for the help. I was off doing other things that I had forgotten about this completely.
clayg reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fantix
Merge branch 'master' into Vizonex/master
38a03fe
fantix
fantix approved these changes Oct 10, 2025
View reviewed changes
@fantix
fantix merged commit b55f5fe into MagicStack:master Oct 10, 2025
fantix added a commit that referenced this pull request Oct 10, 2025
@fantix
httptools 0.7.0
b04ab82 
Changes
=======

* Modernize packaging and fix CI (#130)
  Drop Python 3.8, add Python 3.14
  Use Cython 3.1.0
  Bump llhttp to 9.3.0
  (by @ngoldbaum @Carreau @fantix in 59bf94f for #129)

* Static Type-checking for httptools (#100)
  (by @Vizonex @KRRT7 in b55f5fe for #100)
@fantix fantix mentioned this pull request Oct 10, 2025
httptools 0.7.0 #131
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fantix fantix fantix approved these changes
+1 more reviewer
@DABND19 DABND19 DABND19 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Vizonex @KRRT7 @DABND19 @fantix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.