GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix missing CR is some tests by mgorny · Pull Request #112 · MagicStack/httptools

Conversation

@mgorny

@mgorny mgorny commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

Some of the tests explicitly add "\r" to line endings but fail to do so in empty lines. This causes parsing failures in llhttp-9. Fix them to use CRLF consistently across all lines.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mgorny
Fix missing CR is some tests
89ad5b4 
Some of the tests explicitly add "\r" to line endings but fail to do so
in empty lines.  This causes parsing failures in llhttp-9.  Fix them
to use CRLF consistently across all lines.
elprans
elprans approved these changes Oct 16, 2024
View reviewed changes
@elprans
elprans merged commit 21a199d into MagicStack:master Oct 16, 2024
@mgorny
mgorny deleted the fix-crlf branch October 16, 2024 17:35
@mgorny

mgorny commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
elprans added a commit that referenced this pull request Oct 16, 2024
@elprans
httptools 0.6.3
5e720bf 
Fixes
=====

* Fix missing CR is some tests
  (by @mgorny in 21a199d for #112)

* Bump bundled llhttp to 9.2.1
  Fixes CVE-2024-27982
  (by @elprans in 560bd9e for #113)
@elprans elprans mentioned this pull request Oct 16, 2024
httptools 0.6.3 #114
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elprans elprans elprans approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mgorny @elprans
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.