GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — restore uvloop.new_event_loop and other missing uvloop members to typing by graingert · Pull Request #573 · MagicStack/uvloop

Conversation

@graingert

@graingert graingert commented Oct 14, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Kludex reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
graingert
graingert commented Oct 14, 2023
View reviewed changes
Comment thread uvloop/__init__.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
@graingert
graingert force-pushed the uvloop-missing-nel-install-elp-etc branch from e08494f to 83fbb49 Compare October 14, 2023 11:21
graingert
graingert commented Oct 14, 2023
View reviewed changes
Comment thread uvloop/__init__.pyi

@graingert graingert Oct 14, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this file removed the useful members like 'new_event_loop' which is needed for asyncio.Runner(...)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
graingert
graingert commented Oct 14, 2023
View reviewed changes
Comment thread uvloop/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert
graingert commented Oct 14, 2023
View reviewed changes
Comment thread uvloop/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert
graingert commented Oct 14, 2023
View reviewed changes
Comment thread uvloop/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@graingert
graingert force-pushed the uvloop-missing-nel-install-elp-etc branch 2 times, most recently from 0370a92 to ec9c6ce Compare October 14, 2023 11:40
@graingert graingert changed the title add missing uvloop members to uvloop/__init__.pyi restore uvloop.new_event_loop and other missing uvloop members to typing Oct 14, 2023
graingert
graingert commented Oct 14, 2023
View reviewed changes
Comment thread uvloop/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert
graingert commented Oct 14, 2023
View reviewed changes
Comment thread uvloop/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@graingert
restore missing uvloop members to uvloop typing
7ea847c
@graingert
graingert force-pushed the uvloop-missing-nel-install-elp-etc branch from d887fa4 to 7ea847c Compare October 14, 2023 11:55
@graingert
flake8
1ea3392
@graingert
graingert marked this pull request as ready for review October 14, 2023 12:18
@graingert

graingert commented Oct 14, 2023

Copy link
Copy Markdown
Contributor Author

@fantix can I get a review on this please? It's blocking mypy in unicorn
Kludex reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fantix
fantix reviewed Oct 15, 2023
View reviewed changes
Comment thread uvloop/__init__.py
loop.set_debug(debug)
return loop.run_until_complete(wrapper())
finally:
if _typing.TYPE_CHECKING:

@fantix fantix Oct 15, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just inline the typing and omit this TYPE_CHECKING check?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@graingert graingert Oct 15, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, if you see the history of the PR, but it took too many changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@fantix fantix Oct 15, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now. What about adding new_event_loop to __init__.pyi?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@graingert graingert Oct 15, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that first also and it means the other members aren't type checked

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
fantix
fantix approved these changes Oct 15, 2023
View reviewed changes
Comment thread uvloop/__init__.py
loop.set_debug(debug)
return loop.run_until_complete(wrapper())
finally:
if _typing.TYPE_CHECKING:

@fantix fantix Oct 15, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now. What about adding new_event_loop to __init__.pyi?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@fantix
fantix merged commit 5c500ee into MagicStack:master Oct 15, 2023
@graingert
graingert deleted the uvloop-missing-nel-install-elp-etc branch October 15, 2023 17:11
@graingert graingert mentioned this pull request Oct 15, 2023
Support Python 3.12 Kludex/uvicorn#2129
Closed
@fantix fantix mentioned this pull request Oct 15, 2023
__init__.pyi added on #570 breaks mypy #575
Closed
fantix added a commit that referenced this pull request Oct 22, 2023
@fantix
uvloop 0.19.0
6c770dc 
Changes
=======

* Drop support of Python 3.7 and update CI (#578)
  (by @fantix in ee5ad26 for #578)

Fixes
=====

* Restore uvloop.new_event_loop and other missing uvloop members to typing (#573)
  (by @graingert in 5c500ee for #573)

* Fix docstring of loop.shutdown_default_executor (#535)
  (by @Gelbpunkt in 919da56 for #535)

* Fix CI status badge (#522)
  (by @shuuji3 in 0e9ff6c for #522)
@fantix fantix mentioned this pull request Oct 22, 2023
uvloop 0.19.0 #581
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fantix fantix fantix approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@graingert @fantix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.