GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Don't override task factory's eager_start default by chrisjbillington · Pull Request #779 · MagicStack/uvloop

Conversation

chrisjbillington commented Oct 16, 2026

Copy link

Copy Markdown

PR #748 introduced a regression by passing eager_start=None to the
task factory when not provided by the caller. On Python 3.14 this is
interpreted as False, overriding asyncio.eager_task_factory's
default of eager_start=True and resulting in non-eager tasks. On
Python 3.13, it's a TypeError , since eager_task_factory and user
factories with the (loop, coro, *, name=None, context=None) signature
do not accept an eager_start argument at all.

Forward eager_start to the factory and to Task only when provided by
the caller. This matches the behaviour of asyncio's loop.

Add tests for behaviour when eager_start=False and when not provided.

Fixes #754 (the TypeError on Python 3.13).

Disclosure: Bug found and patch and tests were written by Claude Fable 5.1. But I can confirm the bug on 3.14 and that this fixes it, and the reason for the regression is obvious.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Don't override task factory's eager_start default

ca901bb

PR MagicStack#748 introduced a regression by passing `eager_start=None` to the
task factory when not provided by the caller. On Python 3.14 this is
interpreted as `False`, overriding `asyncio.eager_task_factory`'s
default of `eager_start=True` and resulting in non-eager tasks. On
Python 3.13, it's a `TypeError` , since `eager_task_factory` and user
factories with the `(loop, coro, *, name=None, context=None)` signature
do not accept an `eager_start` argument at all.

Forward `eager_start` to the factory and to `Task` only when provided by
the caller. This matches the behaviour of `asyncio`'s loop.

Add tests for behaviour when `eager_start=False` and when not provided.

chrisjbillington force-pushed the fix-eager-task-factory branch from 0d44045 to ca901bb Compare

October 16, 2026 10:30

chrisjbillington mentioned this pull request

Oct 26, 2026

start_tls() returns a closed transport instead of raising when the client disconnects before the handshake (for eager tasks) #784

Open

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: create_task() got an unexpected keyword argument 'eager_start'

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.