GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(loop): support eager_start in loop.create_task by samypr100 · Pull Request #748 · MagicStack/uvloop

Conversation

@samypr100

@samypr100 samypr100 commented Apr 25, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR adds basic support for eager_start kwarg in loop.create_task.

Closes #746, #718

It also adjusts loop.pyi to mimic typeshed more closely as the type hints I was getting on my editor were not the ones I'd expect signature wise.

Currently it relies on these two PR's from being merged

  • fix(build): use packaging instead of relying on pkg_resources from setuptools #742
  • fix(tests): explicit yield in test_create_ssl_server_manual_connection_lost #743

I tested this manually on Linux and OSX by building uvloop from the branch and running it on eager_start workloads on python 3.13 and 3.14.

Disclosure: This PR is made by human-only contribution without AI generated code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tjkuson reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@samypr100 samypr100 mentioned this pull request Apr 25, 2026
support **kwargs on loop.create_task like in 3.13 and 3.14 #746
Closed
@samypr100
samypr100 force-pushed the eager branch from bd7fc03 to 726a75d Compare April 28, 2026 21:00
@samypr100
samypr100 marked this pull request as ready for review April 29, 2026 01:03
@tjkuson

tjkuson commented May 1, 2026

Copy link
Copy Markdown

Tested this patch locally and it seems to work.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fantix
fantix approved these changes May 1, 2026
View reviewed changes
@samypr100
samypr100 force-pushed the eager branch from d74671b to 909405c Compare May 2, 2026 22:43
@samypr100
feat: support eager_start kwarg
f2b660a
@samypr100
samypr100 force-pushed the eager branch from 909405c to f2b660a Compare May 7, 2026 20:55
@samypr100

samypr100 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@fantix Any luck we can move forward here? Thank you!

fantix reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@fantix
fantix merged commit 3cbb095 into MagicStack:master Jul 14, 2026
17 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@endafarrell endafarrell mentioned this pull request Jul 15, 2026
TypeError: create_task() got an unexpected keyword argument 'eager_start' #754
Open
@samypr100
samypr100 deleted the eager branch July 26, 2026 13:36
@fantix fantix mentioned this pull request Sep 30, 2026
uvloop 0.23.0 #768
Merged
jensbjorgensen pushed a commit to jensbjorgensen/uvloop that referenced this pull request Oct 6, 2026
@fantix
uvloop 0.23.0
c5f7deb
Changes
=======

* Add Python 3.15 and 3.15t wheel builds and CI coverage (MagicStack#758)
  (by @honglei @fantix in f7c0547)

* Add support for the `eager_start` keyword argument in create_task() (MagicStack#748)
  (by @samypr100 in 3cbb095 for MagicStack#746 MagicStack#718)

* Add thread name prefix to the default thread pool executor (MagicStack#636)
  (by @inikolaev @fantix in 0582f94 for MagicStack#562)

* Add support for special hostname `<broadcast>` (MagicStack#592)
  (by @jpbede in 3060ceb for MagicStack#540)

* Upgrade libuv to v1.52.1 (MagicStack#753)
  (by @fantix in e8efea4 for MagicStack#752)

* Improve performance by using Python C API to enter/exit context (MagicStack#627)
  (by @tarasko in 837ef22)

* Improve performance/latency of Transport.write (MagicStack#619)
  (by @tarasko in 1d9b6e0)

* Replace some SSL vectorcall with direct methods (MagicStack#626)
  (by @tarasko in 6a27cbe)

* Optimize SSL buffered reads using C values (MagicStack#629)
  (by @tarasko in a308f75)

Fixes
=====

* Detach socket on create_connection cancellation to prevent fd double-close (MagicStack#740)
  (by @junjzhang @fantix in dc680eb for MagicStack#645 MagicStack#738)

* Remove `loop._ready_len` in favor of `len(loop._ready)` (MagicStack#721)
  (by @x42005e1f in 5910a18 for MagicStack#720)

* Prefer inspect.iscoroutinefunction (MagicStack#705)
  (by @MatthieuDartiailh in fd65027 for MagicStack#703)

* Fix context tests by explicitly yielding after run_in_executor (MagicStack#743)
  (by @samypr100 in 6cd24cb)

* Fix test_create_connection_open_con_addr with Python 3.13.9+ (MagicStack#713)
  (by @shadchin in b93141a for MagicStack#701)

* Skip flaky test_cancel_post_init on asyncio 3.13+ (MagicStack#714)
  (by @fantix in 3ea5c85 for MagicStack#709)

* Fix flaky test_fs_event (MagicStack#717)
  (by @fantix in 8da4547)

* Use C __atomic builtins for debug counters (MagicStack#719)
  (by @fantix in 836e3b2)

* Update the example to work with Python 3.14 (MagicStack#710)
  (by @Jamie-Chang in b74c2f1)

Build
=====

* Replace pkg_resources with packaging and use Cython 3.1 (MagicStack#742)
  (by @samypr100 in b377b7c for MagicStack#729)

* Remove wheel as a build dependency (MagicStack#696)
  (by @DimitriPapadopoulos in 173e88c)

* Support any number of flags in UVLOOP_OPT_CFLAGS (MagicStack#630)
  (by @mgorny in 963a5f3)
chrisjbillington added a commit to chrisjbillington/uvloop that referenced this pull request Oct 16, 2026
@chrisjbillington
Don't override task factory's eager_start default
2ae5ca6
PR MagicStack#748 introduced a regression by passing `eager_start=None` to the
task factory when not provided by the caller. On Python 3.14 this is
interpreted as `False`, overriding `asyncio.eager_task_factory`'s
default of `eager_start=True` and resulting in non-eager tasks. On
Python 3.13, it's a `TypeError` , since `eager_task_factory` and user
factories with the `(loop, coro, *, name=None, context=None)` signature
do not accept an `eager_start` argument at all.

Forward `eager_start` to the factory and to `Task` only when provided by
the caller. This matches the behaviour of `asyncio`'s loop.

Add tests for behaviour when `eager_start=False` and when not provided.
chrisjbillington added a commit to chrisjbillington/uvloop that referenced this pull request Oct 16, 2026
@chrisjbillington
Don't override task factory's eager_start default
0d44045
PR MagicStack#748 introduced a regression by passing `eager_start=None` to the
task factory when not provided by the caller. On Python 3.14 this is
interpreted as `False`, overriding `asyncio.eager_task_factory`'s
default of `eager_start=True` and resulting in non-eager tasks. On
Python 3.13, it's a `TypeError` , since `eager_task_factory` and user
factories with the `(loop, coro, *, name=None, context=None)` signature
do not accept an `eager_start` argument at all.

Forward `eager_start` to the factory and to `Task` only when provided by
the caller. This matches the behaviour of `asyncio`'s loop.

Add tests for behaviour when `eager_start=False` and when not provided.
@chrisjbillington chrisjbillington mentioned this pull request Oct 16, 2026
Don't override task factory's eager_start default #779
Open
chrisjbillington added a commit to chrisjbillington/uvloop that referenced this pull request Oct 16, 2026
@chrisjbillington
Don't override task factory's eager_start default
ca901bb
PR MagicStack#748 introduced a regression by passing `eager_start=None` to the
task factory when not provided by the caller. On Python 3.14 this is
interpreted as `False`, overriding `asyncio.eager_task_factory`'s
default of `eager_start=True` and resulting in non-eager tasks. On
Python 3.13, it's a `TypeError` , since `eager_task_factory` and user
factories with the `(loop, coro, *, name=None, context=None)` signature
do not accept an `eager_start` argument at all.

Forward `eager_start` to the factory and to `Task` only when provided by
the caller. This matches the behaviour of `asyncio`'s loop.

Add tests for behaviour when `eager_start=False` and when not provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fantix fantix fantix approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support **kwargs on loop.create_task like in 3.13 and 3.14

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@samypr100 @tjkuson @fantix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.