GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix running of setup.py test with recent setuptools. by elprans · Pull Request #84 · MagicStack/uvloop

Conversation

@elprans

@elprans elprans commented Mar 30, 2017

Copy link
Copy Markdown
Member

Referencing "setup" in the "test_suite" setup() argument leads to
setup.py being executed twice, which leads to a broken command
behaviour.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@elprans
Fix running of setup.py test with recent setuptools.
39f679a 
Referencing "setup" in the "test_suite" setup() argument leads to
setup.py being executed twice, which leads to a broken command
behaviour.
@elprans
elprans requested a review from 1st1 March 30, 2017 14:51
@elprans elprans self-assigned this Mar 30, 2017
@1st1
1st1 merged commit be920ea into master Mar 30, 2017
@1st1
1st1 deleted the fix-setup-test branch November 17, 2017 19:24
@fantix fantix mentioned this pull request Sep 9, 2022
building wheel from sdist fails #320
Closed
fantix added a commit that referenced this pull request Sep 9, 2022
@fantix
Partially revert "Fix running of setup.py test with recent setuptools. (
2ad87d1 
#84)"

This partially reverts commit be920ea.

Fixes #320
@fantix fantix mentioned this pull request Sep 9, 2022
Drop hack in setup.py in finalize_options #492
Merged
fantix added a commit that referenced this pull request Sep 9, 2022
@fantix
Partially revert "Fix running of setup.py test with recent setuptools. (
2f1bc83 
#84)"

This partially reverts commit be920ea.

Fixes #320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@elprans elprans

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@elprans @1st1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.