Description

mmuharem

opened on Jul 6, 2018

Issue body actions

Hey Nathan,

I've been able to get the AttachmentManager plugin working on MessageKit 1.0 from MessageInputBar 0.2 using example code written in the InputAccessoryBar 2.1, however, I am unable to successfully get AutoCompleteManager working. The problem that I find is that when I enter in the prefix, @, the table appears but is blank.

I thought this was peculiar so I then started to print out the users that were being returned in the

'func autocompleteManager(_ manager: AutocompleteManager, autocompleteSourceFor prefix: String) -> [AutocompleteCompletion] ',

and it seems to be a loop that continues to run while the prefix exists (note the scroll indicator on the right. When I started to take the screenshot, it was in the middle of scroll bar). Note, I do not find this behavior in the InputAccessoryBar project. My guess is that this would explain why the table is not being updated as the values continue to be updated too quickly for the table to register. I thought this had to do with the asynccompletions, so I removed those but to no avail.

Any help in this matter would be appreciated!

Activity

1. nathantannar4 commented on Jul 6, 2018

   

   nathantannar4

   on Jul 6, 2018

   Member

   More actions

   Thanks, I introduced this bug when trying to fix another. I'll push a fix soon.

   _{Sent with GitHawk}
2. nathantannar4 commented on Jul 6, 2018

   

   nathantannar4

   on Jul 6, 2018

   Member

   More actions

   Thanks for your patience. Still haven't fully released this yet 🙂

   _{Sent with GitHawk}
3. nathantannar4

   added a commit that references this issue on Jul 6, 2018

   Fix for issue #7, update copyright

   8d0c2a2
4. SD10 commented on Jul 6, 2018

   

   SD10

   on Jul 6, 2018

   Member

   More actions

   This weekend this should be usable from MessageKit/MessageKit branch development. It won't be on master until the official 2.0 release. Which is likely still a few weeks away. Fwiw, I'm using the MessageKit/MessageKit branch secret-branch for my work -- this change could be merged there as well
5. mmuharem commented on Jul 6, 2018

   

   mmuharem

   on Jul 6, 2018

   Author

   More actions

   I appreciate the help Nathan and Steven, and the update of MessageInputBar 0.2.1!

   I was able to use the development branch and the MessageInputBar 0.2.1 in order to get a fully working autocomplete and attachment manager built.

   I did try with the secret-branch but there was a slight UI issue when you do an @ mention first and then try to add a picture second - it was not showing the tableview in the top stack view as there were layout constraints that broke. Just an FYI of my experience

   Again, the help was very much appreciated! Keep up the great work!
7. nathantannar4 commented on Sep 18, 2018

   

   nathantannar4

   on Sep 18, 2018

   Member

   More actions

   @benbenz you have to be using MessageKit 1.1 which is in pre release on the MessageKit development branch

   _{Sent with GitHawk}
9. SD10

   added

   questionFurther information is requestedFurther information is requested

   on Sep 24, 2018

Issue actions