GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — At `<div x=/**/`, completion insertText should be wrapped in braces · Pull Request #21372 · microsoft/TypeScript

Conversation

@ghost

@ghost Deleted user (ghost) commented Jan 23, 2018

Copy link
Copy Markdown

Fixes #21341

Includes a fix from #21330 but I would prefer #21342, so must wait on that to merge before merging this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andy Hanson
At <div x=/**/, completion insertText should be wrapped in braces
8486bf2
@ghost
ghost requested a review from Armando Aguirre (armanio123) January 23, 2018 21:45
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Jan 23, 2018

Copy link
Copy Markdown
Member

How does this work with string literal completions in these locations?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

Deleted user (ghost) commented Jan 23, 2018 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

getStringLiteralCompletionEntries goes through a different code path since it doesn't use symbols, so it won't be affected by this. (Also, you have to write "" to get the string literal completions -- maybe we should reconsider that now that we have insertText?) I'd write a test for that, but due to #21374 we will crash when trying to get details for the completion.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Jan 24, 2018
View reviewed changes
@mhegazy

Mohamed Hegazy (mhegazy) commented Jan 24, 2018

Copy link
Copy Markdown
Contributor

Andy (Andrewkraft) (@Andy-MS) can you also port this to release-2.7 as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

Deleted user (ghost) commented Jan 24, 2018 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

Waiting on #21342 (or #21330)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost
ghost force-pushed the completionsJsxAttributeInitializer branch from caf23d6 to 9f25d82 Compare January 25, 2018 16:20
Andy Hanson
Merge branch 'master' into completionsJsxAttributeInitializer
0488325
@ghost
ghost force-pushed the completionsJsxAttributeInitializer branch from 9f25d82 to 0488325 Compare January 25, 2018 16:20
@ghost ghost mentioned this pull request Jan 25, 2018
Use insertText to add string literal completions #21408
Closed
@ghost
ghost merged commit dcd3b5e into master Jan 25, 2018
@ghost
ghost deleted the completionsJsxAttributeInitializer branch January 25, 2018 17:02
ghost pushed a commit that referenced this pull request Jan 25, 2018
Andy
At <div x=/**/, completion insertText should be wrapped in braces (#…
8cac17b 
…21372)
@ghost ghost mentioned this pull request Jan 25, 2018
Release 2.7 completions jsx attribute initializer #21409
Merged
ghost pushed a commit that referenced this pull request Jan 25, 2018
Andy
At <div x=/**/, completion insertText should be wrapped in braces (#…
a453149 
…21372) (#21409)
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@armanio123 Armando Aguirre (armanio123) Awaiting requested review from armanio123

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't provide completions after = in JSX

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DanielRosenwasser @mhegazy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.