GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix bug: Support `this.` completions even when isGlobalCompletion is false · Pull Request #21330 · microsoft/TypeScript

Conversation

@ghost

@ghost Deleted user (ghost) commented Jan 22, 2018

Copy link
Copy Markdown

Fixes #21320

Does anyone know why we return isGlobalCompletion as part of a CompletionInfo and why it is not true in an expression context?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andy Hanson
Fix bug: Support this. completions even when isGlobalCompletion is …
40953b0 
…false
@ghost
ghost requested review from Daniel Rosenwasser (DanielRosenwasser), Armando Aguirre (armanio123) and Mohamed Hegazy (mhegazy) January 22, 2018 16:15
@sheetalkamat

Sheetal Nandi (sheetalkamat) commented Jan 22, 2018

Copy link
Copy Markdown
Member

#11338 added isGlobalCompletion
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jan 22, 2018
Remove isGlobalCompletionScope #21342
Closed
At <div x=/**/, completion insertText should be wrapped in braces #21372
Merged
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Jan 24, 2018
View reviewed changes
@mhegazy

Mohamed Hegazy (mhegazy) commented Jan 24, 2018

Copy link
Copy Markdown
Contributor

We also need to move this to release-2.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost
ghost merged commit 0b7f6d5 into master Jan 25, 2018
@ghost
ghost deleted the completionkindnone branch January 25, 2018 15:42
ghost pushed a commit that referenced this pull request Jan 25, 2018
Andy
Fix bug: Support this. completions even when isGlobalCompletion is …
ee0eef5 
…false (#21330)
@ghost ghost mentioned this pull request Jan 25, 2018
Fix bug: Support this. completions even when isGlobalCompletion is false (#21330) #21407
Merged
ghost pushed a commit that referenced this pull request Jan 25, 2018
Andy
Fix bug: Support this. completions even when isGlobalCompletion is …
cac6052 
…false (#21330) (#21407)
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser
@armanio123 Armando Aguirre (armanio123) Awaiting requested review from armanio123

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sheetalkamat @mhegazy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.