GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — DDC support for high-end M2 (Pro/Max/Ultra) systems by waydabber · Pull Request #1404 · MonitorControl/MonitorControl

Conversation

@waydabber

@waydabber waydabber commented Jul 31, 2023

Copy link
Copy Markdown
Member

Added DDC support for high-end M2 (Pro/Max/Ultra) systems using displays connected via USB-C/ThunderBolt/DisplayPort and HDMI.

(note: somebody with an M2 Pro/Max/Ultra Mac should test it, I am still on M1 :))

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sswensen, nic, devantler, alexforster, the0neyouseek, dmexs, dellhem, niranjan94, robofearth, frunika, and 5 more reacted with heart emoji
All reactions
  • ❤️ 15 reactions
@waydabber
Added DDC support for high-end M2 (Pro/Max/Ultra) systems using displ…
757ba4a
…ays connected via USB-C/ThunderBolt/DisplayPort and HDMI.
@waydabber waydabber mentioned this pull request Jul 31, 2023
DDC control does not work on M2 Pro/Max systems #1301
Closed
3 tasks done
@JerryZhangZZY

JerryZhangZZY commented Jul 31, 2023

Copy link
Copy Markdown

Could you post a compiled .dmg file so that I can test it?

renaudguerin reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waydabber

waydabber commented Jul 31, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Sure. This build is unsigned and not notarized so you'll need to manually allow it to run under Security&Privacy. Let me know if you did try it so I can delete this.

[Removed]

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JerryZhangZZY

JerryZhangZZY commented Aug 1, 2023 •
edited by waydabber
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Sure. This build is unsigned and not notarized so you'll need to manually allow it to run under Security&Privacy. Let me know if you did try it so I can delete this.

[Removed]

DDC works perfectly on M2 Pro, nicely done mate!

jacobgad and robofearth reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waydabber

waydabber commented Aug 1, 2023

Copy link
Copy Markdown
Member Author

Great! Thanks for the feedback!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

waydabber added a commit to waydabber/AppleSiliconDDC that referenced this pull request Aug 2, 2023
@waydabber
Update AppleSiliconDDC.swift
fd009ad
Updated to work on M2 Pro/Max/Ultra systems. Same as version added in this PR: MonitorControl/MonitorControl#1404
@nic

nic commented Aug 6, 2023

Copy link
Copy Markdown

Amazing! DDC works sweetly fine on M2 Ultra. Awesome job, dude! 🤩

waydabber reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@devantler

devantler commented Aug 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

@waydabber Awesome work! 😃 Sadly, I was not able to make this work. The volume is not affected when I change the volume slider with the Apple keys or the slider in MonitorControl.

image

  • LG C2 connected on HDMI_2 (can this affect the logic?)
  • The build has been allowed under Security&Policy>Accessiblity

Can it be related to running Sonoma?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waydabber

waydabber commented Aug 8, 2023

Copy link
Copy Markdown
Member Author

@waydabber Awesome work! 😃 Sadly, I was not able to make this work. The volume is not affected when I change the volume slider with the Apple keys or the slider in MonitorControl.

image

  • LG C2 connected on HDMI_2 (can this affect the logic?)
  • The build has been allowed under Security&Policy>Accessiblity

Can it be related to running Sonoma?

Sadly the LG C2 (as most TVs) does not support DDC. :(

devantler reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@alexforster

alexforster commented Aug 8, 2023

Copy link
Copy Markdown

Worked on my new MBP Mac14,9 driving two LG 27UN880-B monitors.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@devantler

devantler commented Aug 8, 2023

Copy link
Copy Markdown

Sadly the LG C2 (as most TVs) does not support DDC. :(

Ah damn. Back to proxy-audio-device for me then 🙂

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waydabber
waydabber requested a review from the0neyouseek August 10, 2023 08:33
the0neyouseek
the0neyouseek approved these changes Aug 10, 2023
View reviewed changes

@the0neyouseek the0neyouseek left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 LGTM ! Thank you so much for the PR, everything looks good as far as I can see !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nic reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@waydabber

waydabber commented Aug 10, 2023

Copy link
Copy Markdown
Member Author

Thanks @the0neyouseek ! :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nic
nic approved these changes Aug 14, 2023
View reviewed changes
@pakal-org

pakal-org commented Aug 14, 2023

Copy link
Copy Markdown

Can we expect a release soon ?

Thanks

l0vecr4ft, dmexs, and karnkittik reacted with eyes emoji
All reactions
  • 👀 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waydabber
waydabber merged commit c5c8bf1 into main Aug 14, 2023
@waydabber
waydabber deleted the update branch August 14, 2023 16:08
@waydabber

waydabber commented Aug 14, 2023

Copy link
Copy Markdown
Member Author

Can we expect a release soon ?

Thanks

I am not sure, I can't sign a build for release, it depends on the team. You can of course build a version using XCode anytime.

pakal-org and stepancheg reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pakal-org

pakal-org commented Aug 14, 2023

Copy link
Copy Markdown

I thought that project was dead...
I can wait a little more :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waydabber

waydabber commented Aug 14, 2023

Copy link
Copy Markdown
Member Author

@pakal-org, the project is not dead, just in a bit slow-to-respond mode...

Note: if you don't want to build a release yourself, you can try BetterDisplay meanwhile as it has DDC brightness control for the M2 Pro for free - try https://github.com/waydabber/BetterDisplay/releases/tag/v2.0.6-pre-release

kaeferfreund reacted with thumbs up emoji kaeferfreund reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pakal-org

pakal-org commented Aug 14, 2023

Copy link
Copy Markdown

I know about your product :)
I like the "lightness" of Monitor Control ...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waydabber

waydabber commented Aug 14, 2023

Copy link
Copy Markdown
Member Author

Yes, I can understand that. :)

kaeferfreund reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dellhem

dellhem commented Aug 24, 2023

Copy link
Copy Markdown

What a flex! Fixing the competition's issues 😆 Great work, @waydabber 😘

kaeferfreund and waydabber reacted with laugh emoji
All reactions
  • 😄 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cgull

cgull commented Aug 25, 2023

Copy link
Copy Markdown

Thanks, @waydabber -- this works fine for me on a 14" M2 MBP Mac14,5 and two LG LS27A800U monitors on USB-C cables, after building e038b89.

Maintainers, what blocks generating a new release?

waydabber reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JoniVR

JoniVR commented Aug 25, 2023

Copy link
Copy Markdown
Member

We'll do a new release with this fix soon.

l0vecr4ft, vildhjarta8, cgull, L4rS6, tardieu, julienarnoux, alexforster, and kaeferfreund reacted with hooray emoji
All reactions
  • 🎉 8 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kaeferfreund

kaeferfreund commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

I have compiled it on my own and it works like a charm, very stable so far :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lestmak

lestmak commented Sep 11, 2023

Copy link
Copy Markdown

On a Mac Mini M2 Pro with an LG UltraWide Monitor 38WN95C-W. Working beautifully and perfectly. Thanks for this!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@frunika

frunika commented Sep 12, 2023

Copy link
Copy Markdown

Work's perfect. Thanks! :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@the0neyouseek the0neyouseek the0neyouseek approved these changes
+1 more reviewer
@nic nic nic approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

13 participants

@waydabber @JerryZhangZZY @nic @devantler @alexforster @pakal-org @dellhem @cgull @JoniVR @kaeferfreund @lestmak @frunika @the0neyouseek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.