GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Update translations for Simplified Chinese and Traditional Chinese by betacat-ha · Pull Request #1417 · MonitorControl/MonitorControl

Conversation

betacat-ha commented Aug 24, 2023

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

betacat-ha added 2 commits

August 24, 2023 20:47


          Update zh-Hans translation

90c9509


          Update zh-Hant-TW translation

9829dcd

igorwendt approved these changes

Aug 24, 2023

View reviewed changes

waydabber approved these changes

Aug 24, 2023

View reviewed changes

waydabber left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

the0neyouseek merged commit e038b89 into MonitorControl:main

Aug 24, 2023

toto6038 reviewed

Sep 10, 2023

View reviewed changes

Comment thread

MonitorControl/UI/zh-Hant-TW.lproj/Main.strings


		/* Class = "NSTextFieldCell"; title = "Control your external displays brightness, contrast and volume directly from your Mac, using menulet sliders or the keyboard, including native Apple keys."; ObjectID = "Mh5-1A-apq"; */
		"Mh5-1A-apq.title" = "Control your external displays brightness, contrast and volume directly from your Mac, using menulet sliders or the keyboard, including native Apple keys.";
		"Mh5-1A-apq.title" = "使用菜單上的滑桿或者鍵盤（支持Apple原生快捷鍵），直接從Mac控制外接螢幕的亮度、對比度和音量。";

toto6038 Sep 10, 2023

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation in Traditional Chinese is actually erroneous and doesn't follow the convention of the language. Please do not simply convert the characters from Simplified Chinese to Traditional Chinese. As the practice can cause confusion to both Traditional Chinese users and translators.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brlin-tw reacted with thumbs up emoji

All reactions

👍 1 reaction

betacat-ha Sep 10, 2023

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for that. I noticed that some sentences weren't localized in Traditional Chinese, so I translated them together.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

toto6038 reacted with heart emoji

All reactions

❤️ 1 reaction

toto6038 Sep 10, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping out. Feel free to mention me or assign me next time!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brlin-tw and mattwang44 reacted with thumbs up emoji

All reactions

👍 2 reactions

toto6038 added a commit to toto6038/MonitorControl that referenced this pull request

Sep 10, 2023


          fix: correct zh-TW translation in MonitorControl#1417

b742d9e

toto6038 mentioned this pull request

Sep 10, 2023

fix: correct zh-TW translation in #1417 #1426

Merged

waydabber pushed a commit that referenced this pull request

Sep 10, 2023


          fix: correct zh-TW translation in #1417 (#1426)

e38f8c4

Reviewers

waydabber

waydabber approved these changes

+2 more reviewers

toto6038

toto6038 left review comments

igorwendt

igorwendt approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

betacat-ha commented Aug 24, 2023

Uh oh!

waydabber left a comment

Choose a reason for hiding this comment

Uh oh!

toto6038 Sep 10, 2023

Choose a reason for hiding this comment

Uh oh!

betacat-ha Sep 10, 2023

Choose a reason for hiding this comment

Uh oh!

toto6038 Sep 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

toto6038 Sep 10, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.