GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: require devtools-elements.js with the extension mentioned explicitly by sis0k0 · Pull Request #6079 · NativeScript/NativeScript

Conversation

@sis0k0

@sis0k0 sis0k0 commented Jul 17, 2018

Copy link
Copy Markdown
Contributor

This is a workaround for the issue with @ngtools/[email protected], described here: NativeScript/nativescript-dev-webpack#607 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sis0k0
fix(devtools): require .js file explicitly
3f85250 
This is a workaround for the issue with `@ngtools/[email protected]`, described here: NativeScript/nativescript-dev-webpack#607 (comment)
@sis0k0
sis0k0 requested a review from manoldonev July 17, 2018 11:44
@ghost ghost assigned sis0k0 Jul 17, 2018
@ghost ghost added the in progress label Jul 17, 2018
@ns-bot ns-bot added the cla: yes label Jul 17, 2018
@sis0k0 sis0k0 changed the title fix(devtools): require .js file explicitly fix: require devtools-elements.js with the extension mentioned explicitly Jul 17, 2018
manoldonev
manoldonev approved these changes Jul 17, 2018
View reviewed changes
@manoldonev

manoldonev commented Jul 18, 2018

Copy link
Copy Markdown
Contributor

test
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manoldonev
Merge branch 'master' into sis0k0/dynamic-require-js
59c70ed
@ghost ghost assigned manoldonev Jul 18, 2018
@sis0k0
sis0k0 merged commit 8813e9b into master Jul 18, 2018
@ghost ghost removed the in progress label Jul 18, 2018
@sis0k0
sis0k0 deleted the sis0k0/dynamic-require-js branch July 18, 2018 10:38
sis0k0 added a commit that referenced this pull request Jul 18, 2018
@sis0k0
fix: require devtools-elements.js with the extension mentioned explic…
1a15aa2 
…itly (#6079)

This is a workaround for the issue with `@ngtools/[email protected]`, described here: NativeScript/nativescript-dev-webpack#607 (comment)
dtopuzov pushed a commit that referenced this pull request Jul 18, 2018
@sis0k0 @dtopuzov
release: cut the 4.1.1 release (#6084)
4cd3a32 
* fix: require devtools-elements.js with the extension mentioned explicitly (#6079)

This is a workaround for the issue with `@ngtools/[email protected]`, described here: NativeScript/nativescript-dev-webpack#607 (comment)

* release: cut the 4.1.1 release

* chore: Fix TS transpile error with 2.9 (#5906)
vchimev added a commit that referenced this pull request Jun 12, 2019
@vchimev
fix: require devtools-element module
4fc4f59 
#6079
workarounds an issue in @ngtools/webpack which is no more.

Reverting the workaround as:
- the original issue is no more
- the require does not resolve when transpiling `tns-core-modules`
vchimev added a commit that referenced this pull request Jun 13, 2019
@vchimev
fix: require devtools-element module
ff7bd7f 
#6079
workarounds an issue in @ngtools/webpack which is no more.

Reverting the workaround as:
- the original issue is no more
- the require does not resolve when transpiling `tns-core-modules`
vakrilov pushed a commit that referenced this pull request Jun 17, 2019
@vchimev vakrilov
fix: require devtools-element module
d1d9bff 
#6079
workarounds an issue in @ngtools/webpack which is no more.

Reverting the workaround as:
- the original issue is no more
- the require does not resolve when transpiling `tns-core-modules`
@lock

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lock lock Bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@manoldonev manoldonev manoldonev approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@manoldonev manoldonev

@sis0k0 sis0k0

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sis0k0 @manoldonev @ns-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.