GeezerVison

No actionable comments were generated in the recent review. 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

@NathanWalker, (and @coderabbitai), I checked the iOS runtime and it doesn't need an equivalent of this change. Vanilla NativeScript/ios already strips . and .. out of a resolved module path before that path becomes the registry key, so the ./x vs ../x double-instantiation this PR fixes on Android can't happen there.

It's all in ModuleInternalCallbacks.mm:

• NormalizePath() runs the path through stringByStandardizingPath, which canonicalizes . and ... Note the .. collapse is resolved against the real on-disk path (it consults the filesystem and folds symlinks), not a lexical string rewrite like the Android pass: https://github.com/NativeScript/ios/blob/6778dfdd5b436be0dad51f1f64df1e1408d8e76c/NativeScript/runtime/ModuleInternalCallbacks.mm#L50-L66
• That normalize runs on the already-resolved on-disk file right before the path becomes the registry key (absPath isn't touched again before g_moduleRegistry), so ./x and ../x land on one key. Same dedup as this PR, reached by canonicalizing the resolved path rather than collapsing the specifier lexically: https://github.com/NativeScript/ios/blob/6778dfdd5b436be0dad51f1f64df1e1408d8e76c/NativeScript/runtime/ModuleInternalCallbacks.mm#L1317
• It also normalizes each candidate base during resolution: https://github.com/NativeScript/ios/blob/6778dfdd5b436be0dad51f1f64df1e1408d8e76c/NativeScript/runtime/ModuleInternalCallbacks.mm#L1161
• And it standardizes the joined relative path when building the candidate: https://github.com/NativeScript/ios/blob/6778dfdd5b436be0dad51f1f64df1e1408d8e76c/NativeScript/runtime/ModuleInternalCallbacks.mm#L967-L976

So canonicalization on iOS happens earlier and in more places than the single pass here, and both sides end up keying the registry by the same canonical path. No parity PR needed on iOS.

@adrian-niculescu Thanks for the thorough cross-platform investigation. The breakdown is very clear:

• iOS (ModuleInternalCallbacks.mm): canonicalization via stringByStandardizingPath happens at multiple points (path normalization helper, candidate base construction, joined relative path, and registry key assignment), and it's filesystem-aware (resolves symlinks, not just lexical).
• Android (this PR): a single lexical NormalizeDotSegments pass applied to the confirmed on-disk candidate path, just before it becomes the registry key.

Both approaches converge on the same canonical path as the registry key, so ./x and ../x correctly deduplicate on both platforms. No iOS follow-up needed — noted.

Learnt from: adrian-niculescu
URL: https://github.com/NativeScript/android/pull/1977

Timestamp: 2026-06-24T11:37:48.132Z
Learning: In NativeScript, the iOS runtime (`NativeScript/ios`) already prevents `./x` vs `../x` module double-instantiation without any additional fix. `NormalizePath()` in `NativeScript/runtime/ModuleInternalCallbacks.mm` (around L50-L66) uses `stringByStandardizingPath` which canonicalizes `.` and `..` segments by consulting the real filesystem (folds symlinks too, not just a lexical rewrite). This normalization is applied at multiple call sites: candidate base during resolution (~L1161), joined relative path when building candidates (~L967-976), and the final `absPath` just before it is used as the `g_moduleRegistry` key (~L1317). The Android PR `#1977` achieves the same dedup via a single lexical `NormalizeDotSegments` pass on the confirmed on-disk path before it becomes the registry key. No parity PR is needed on iOS.