GeezerVison

The inspector mutex changes from std::mutex to std::recursive_mutex. A worker test exercises nested logging during object formatting and checks that the worker remains responsive.

Changes: Inspector Lock

Layer / File(s)	Summary
Recursive inspector lock and caller documentation test-app/runtime/src/main/cpp/WorkerWrapper.h, test-app/runtime/src/main/cpp/WorkerWrapper.cpp, test-app/runtime/src/main/cpp/JsV8InspectorClient.cpp, test-app/runtime/src/main/cpp/WorkerInspectorClient.h	inspectorMutex_ changes to std::recursive_mutex. Terminate, CreateInspector, DestroyInspector, and ConsoleLog use the lock. The comments state that console logging may run on the thread holding the worker isolate’s Locker, including the main thread under __runOnMainThread.
Nested console regression test test-app/app/src/main/assets/app/tests/workerNestedConsoleWorker.js, test-app/app/src/main/assets/app/tests/testWorkerNestedConsole.js, test-app/app/src/main/assets/app/mainpage.js	The worker logs an object whose Symbol.toStringTag getter logs "nested", then posts "alive". The test waits for that message before terminating the worker. The app loads the test module.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: edusperoni

Merge Risk: Low · up to e9c09

The change lets a worker terminate re-enter the inspector lock, which should fix the console.log deadlock. The new test's error handler uses an unsupported callback method, so a worker error would surface as a TypeError instead of a clean test failure. Fix this small test issue; otherwise the change looks safe to merge.

Pre-merge checks: 4

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title names the main change: the fix lets a heap-limit terminate re-enter the inspector lock when console.log runs. The raw summary says inspectorMutex_ changes from std::mutex to std::recursive_m…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: the fix lets a heap-limit terminate re-enter the inspector lock when console.log runs. The raw summary says inspectorMutex_ changes from std::mutex to std::recursive_mutex across the worker termination, inspector creation/destruction, and console logging paths. The objectives explain that V8's OnNearHeapLimit calls Terminate() and re-enters the lock on the same thread, which would self-deadlock with a non-recursive mutex. The title therefore matches the core change. It is 84 characters, slightly over the short-title ideal, but still clear and specific.

Generate unit tests (beta)

• Create a new PR

• X
• Mastodon
• Reddit
• LinkedIn

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.