GeezerVison is showing github.com — feat: many new android features by farfromrefug · Pull Request #5774 · NativeScript/nativescript-cli
Conversation
Thought it was time to make that big PR. It is quite impossible now to divide everything as each part depends on the other.
I really hope we can make that work for everyone to enjoy the new features.
I ll try to list them all. Dont hesitate if you have questions
TODO
There is one thing i would like to improve which is this. I commented on the reason why we need that.
Though i am sure we might find a better solution. The issue with the way i did it if that if new task are added (either tools update of maybe through plugin) that list will need to be update which is ugly. I already had to add tasks added by the sentry plugin...
Maybe @triniwiz you know a way to do it better. I know the reason is that by reading the buildMetada task (or the tasks it depends on like those handling jars) gradle thinks buildMetadata uses as an input the output of all those tasks. TBH i dont really understand fully the code of the buildMetadata task ...
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
NathanWalker, vallemar, and MrSnoozles reacted with rocket emoji
Along with that we simply need to have a cli parameter and an option in nativescript.config
# Conflicts:
# lib/services/plugins-service.ts
fix: require.resolve for packages with exports field in package.json
can still be enabled with `generateBuildConfig` and `generateR`
# Conflicts:
# lib/services/log-source-map-service.ts
# lib/services/metadata-filtering-service.ts
# lib/services/test-execution-service.ts
# vendor/gradle-plugin/build.gradle
# Conflicts:
# lib/services/android-plugin-build-service.ts
# vendor/gradle-plugin/build.gradle
# Conflicts:
# CHANGELOG.md
# lib/services/webpack/webpack-compiler-service.ts
# package-lock.json
# package.json
# Conflicts:
# CHANGELOG.md
# lib/commands/config.ts
# lib/common/helpers.ts
# lib/common/logger/logger.ts
# lib/controllers/prepare-controller.ts
# lib/controllers/run-controller.ts
# lib/definitions/project.d.ts
# lib/services/ios-project-service.ts
# lib/services/webpack/webpack-compiler-service.ts
# package-lock.json
# package.json
# tsconfig.json
# Conflicts:
# Gruntfile.js
# lib/services/bundler/bundler.ts
# lib/services/webpack/webpack-compiler-service.ts
# package-lock.json
# package.json
# test/ios-project-service.ts
# test/plugins-service.ts
# test/project-changes-service.ts
# test/services/android/gradle-build-args-service.ts
# vendor/gradle-plugin/build.gradle
# Conflicts:
# lib/commands/build.ts
# package-lock.json
# package.json
# vendor/aab-tool/bundletool.jar
# vendor/gradle-plugin/build.gradle
Uh oh!
There was an error while loading. Please reload this page.
|
|
(d) => d.deviceInfo.identifier === deviceDescriptor.identifier
|
|
|
)[0];
|
|
|
const abis = device.deviceInfo.abis.filter((a) => !!a && a.length)[0];
|
|
|
const regexp = new RegExp(`${abis}.*\.apk`);
|
Check failure
Code scanning / CodeQL
Useless regular-expression character escape
High
The escape sequence '.' is equivalent to just '.', so the sequence may still represent a meta-character when it is used in a
regular expression
Error loading related location
Loading Uh oh!
There was an error while loading. Please reload this page.
.
|
@NathanWalker bumping this trying to see if we could get this for 9.0. I updated the PR and fixed the remaining issues.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
