GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: generate plugin outputs into .plugins folder inside platforms/android by edusperoni · Pull Request #5937 · NativeScript/nativescript-cli

Conversation

@edusperoni

@edusperoni edusperoni commented Dec 16, 2025

Copy link
Copy Markdown
Collaborator

instead of writing the generated .aar into the plugin's node_modules folder, write it to platforms/android/.plugins. This prevents us from modifying node_modules

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@edusperoni

edusperoni commented Dec 16, 2025

Copy link
Copy Markdown
Collaborator Author

@farfromrefug

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@edusperoni edusperoni mentioned this pull request Dec 16, 2025
feat: add generated .aar files from plugins NativeScript/android#1897
Draft
@farfromrefug

farfromrefug commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

@edusperoni I like the idea! it will break plugins though.
right now plugins having dependency on other plugins (or widget-release) had to had direct dependency on the jar. and we had to use it with path to the node modules folder.

actually what you are doing could make things simpler if the plugins folder is added to dependencies repositories.
then i could simply add the jar name as a dép and it should be found

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@edusperoni

edusperoni commented Dec 17, 2025

Copy link
Copy Markdown
Collaborator Author

I don't believe that would change? We still use what's inside the node_modules, but when we generate the aar we put the artifact in the platforms folder. Do you think that wouldn't work?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@farfromrefug

farfromrefug commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

@edusperoni if i understand the output aar is now in platforms/android/plugins instead of in each node_modules/{plugin}/platforms/android ?
If so my plugins need an update. Here is an example https://github.com/nativescript-community/gesturehandler/blob/master/packages/gesturehandler/platforms/android/include.gradle#L21

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@edusperoni

edusperoni commented Dec 17, 2025

Copy link
Copy Markdown
Collaborator Author

I believe the include.gradle is still parsed in the node modules folder. IRRC it's not a real Gradle file (doesn't get included in full). The decencies are parsed only.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@edusperoni

edusperoni commented Dec 17, 2025

Copy link
Copy Markdown
Collaborator Author

Oh, I see. You're depending on the final artifact. Maybe I'll add some helper functions (some are already present) for plugin developers like getJSDir(dep), getNativeDir(dep) and getDistNativeDir(dep) and accompanying ones for getting the dependencies recursively. This way if we decide to make the native dir fully mirrored inside the platforms dir we can just return a different value for the getNativeDir()

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@farfromrefug

farfromrefug commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

@edusperoni yes that would be awesome.
ABout the The decencies are parsed only. i hope this will be fixed soon as it is part of this #5774. In it now the include.gradle is actually included

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@edusperoni
feat: generate plugin outputs into .plugins folder inside platforms/a…
8bfff15
…ndroid
@edusperoni
edusperoni force-pushed the feat/dont-modify-node-modules branch from 9912983 to 8bfff15 Compare July 2, 2026 20:34
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 00603588-38ce-4a8c-bd52-d72b377bd598

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@edusperoni edusperoni mentioned this pull request Oct 22, 2026
feat(android): org.nativescript:gradle-api, Gradle facts file and opt-in read-only node_modules #6175
Draft
4 of 5 tasks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@edusperoni @farfromrefug
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.