GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||
GeezerVison is showing github.com — feat(android): per-plugin build options, with aarSuffix to break name clashes by farfromrefug · Pull Request #6132 · NativeScript/nativescript-cli Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAndroid plugin configuration now supports optional AAR suffixes. The project service passes per-plugin settings into the build service. AAR naming and Gradle setup use the suffix-aware shortened name. Tests cover default and suffixed output names. ChangesAndroid AAR naming
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR adds optional per-plugin AAR suffixing while preserving default behavior; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant AndroidProjectService
participant AndroidPluginBuildService
participant Gradle
AndroidProjectService->>AndroidPluginBuildService: pass per-plugin aarSuffix
AndroidPluginBuildService->>AndroidPluginBuildService: derive shortened plugin name
AndroidPluginBuildService->>Gradle: configure project with shortened name
Gradle-->>AndroidPluginBuildService: create release AAR
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.