GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — feat(android): --gradleFlavor to build a product flavor by farfromrefug · Pull Request #6133 · NativeScript/nativescript-cli Conversation
Contributor
WhatAn app that declares product flavors in its gradle configuration has no way to tell the CLI which one to build. The task name is built as: const baseTaskName = buildData.androidBundle ? "bundle" : "assemble"; so the CLI always asks for
ns build android --gradleFlavor foo --release # assembleFooRelease ns run android --gradleFlavor foo # assembleFooDebug ns build android --gradleFlavor foo --aab # bundleFooRelease The flavor is capitalized to match gradle's task naming, and a flavor that is already capitalized is left alone. Build outputNo special handling needed. A flavored build lands in which matches the flavored name as is. Tests
NotesFrom https://github.com/Akylas/nativescript-cli. Independent of #6129, #6130, #6131 and #6132, though it adds an option next to
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsAn app that declares product flavors in its gradle configuration could not tell the CLI which one to build - it always ran `assembleDebug` / `assembleRelease`, which fails outright once flavors exist. `--gradleFlavor foo` inserts the flavor into the task name, so the CLI runs `assembleFooDebug`, `assembleFooRelease`, `bundleFooDebug` or `bundleFooRelease`. The flavor is capitalized to match the gradle task naming. The build output does not need any special handling: gradle writes a flavored build to `build/outputs/apk/<flavor>/<buildType>`, which the existing recursive package lookup and its `-.*-(Debug|Release)` regex already cover. Co-Authored-By: Claude Opus 5 <[email protected]>
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
NathanWalker
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |