GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: don't remove groups by name as multiple can coexist by rigor789 · Pull Request #15 · NativeScript/nativescript-dev-xcode

Conversation

@rigor789

@rigor789 rigor789 commented Apr 29, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Removing groups by name will remove valid groups in case there are multiple groups with the same name, ie. the same folder name as part of multiple different folders.

platforms/ios/src/
  Foo/
    Foo1_Files/
      Resources/ <bunch of images>
      Storyboard/
        Foo1.storyboard
    Foo2_Files/
      Resources/ <bunch of images>
      Storyboard/
        Foo2.storyboard

Foo1_Files/Resources and Foo1_Files/Storyboard would be removed causing these resources to be missing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@rigor789
fix: don't remove groups by name as multiple can coexist
01c1701
@cla-bot cla-bot Bot added the cla: yes label Apr 29, 2022
@rigor789
rigor789 merged commit 9f4ca08 into master Apr 29, 2022
@jvaronenka jvaronenka mentioned this pull request Oct 19, 2023
TNSNativeSource gets duplicated in Xcode projects NativeScript/nativescript-cli#5765
Open
3 tasks done
@rigor789
rigor789 deleted the fix/old-group-removal branch January 19, 2024 15:39
@jcassidyav jcassidyav mentioned this pull request Feb 19, 2024
fix: ensure that PbxGroups are not duplicated #17
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@rigor789
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.