GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: ensure that PbxGroups are not duplicated by jcassidyav · Pull Request #17 · NativeScript/nativescript-dev-xcode

Conversation

@jcassidyav

@jcassidyav jcassidyav commented Feb 19, 2024

Copy link
Copy Markdown

This tracks the PbxGroups that are created, to ensure that duplicates are not created while also allowing for the scenario as described in #15 addressing NativeScript/nativescript-cli#5765.

It tracks the groups in an external file so that you can edit the project in XCode and still maintain the link.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jcassidyav
fix: ensure that PbxGroups are not duplicated
b514195
@cla-bot cla-bot Bot added the cla: yes label Feb 19, 2024
@jcassidyav

jcassidyav commented Feb 19, 2024

Copy link
Copy Markdown
Author

@rigor789 I think this will satify the original issue in #15 and the reciently reported duplication issues in the project.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rigor789

rigor789 commented Feb 20, 2024

Copy link
Copy Markdown
Member

Interesting approach - we can give it a go for sure! I was also wondering if we could store this in the pbxproj itself, but I imagine XCode may clean it up if it's an unknown entry...

Interestingly we could also store it as comments above the groups I guess - but anyways these are just ideas, storing in a separate file should be totally fine too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jcassidyav

jcassidyav commented Feb 20, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

Yeah unfortunatly once you do anything, say rename a file the pbxproj gets cleaned up.

Of course editing the project in xcode is probably not that common a thing to do.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rigor789

rigor789 commented Feb 20, 2024

Copy link
Copy Markdown
Member

Ah that's unfortunate - renaming in XCode shouldn't break it, so no-go on that!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rigor789
rigor789 merged commit 99947af into NativeScript:main Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jcassidyav @rigor789
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.