GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — feat: apply webpack HMR updates while a debug app runs by triniwiz · Pull Request #32 · NativeScript/windows Conversation
Member
With webpack, Changes
The CLI side is NativeScript/nativescript-cli (against TestingEnd to end on Windows 11 (Debug, x64): a TypeScript app on webpack 5.99.7, core and
I haven't built the published
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe CLI syncs webpack's hot-update files into bin\app, but nothing told the running app to apply them, so every change restarted the app. Debug hosts now watch LocalState for an ns-livesync marker and call global.__onLiveSync() on the UI thread when it appears, which runs webpack's hot update, as the Android and iOS runtimes do after a LiveSync. The host writes ns-livesync-ready while it watches, so a CLI only relies on the marker when the app can act on it.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
This was referenced
triniwiz
added a commit
to NativeScript/nativescript-cli
that referenced
this pull request
…6174) tryRefreshApplication returned false for webpack, so every change restarted the app even though the hot-update files were already in bin\app. After a sync, the CLI now writes an ns-livesync marker into the app's LocalState. The debug host watches for it and calls global.__onLiveSync(), which runs webpack's hot update (NativeScript/windows#32). The CLI only does this when the host has written ns-livesync-ready, so older hosts still restart. shouldRestart now also restarts on a full sync, as Android and iOS do. That is how the CLI recovers when a hot update fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |