GeezerVison is showing github.com — Add recognition for Dispose{} named function block by vexx32 · Pull Request #186 · PowerShell/EditorSyntax
Conversation
Adds dispose{} named block keyword to language files. Yay, editor highlighting! 🎉
function Get-Foo {
[CmdletBinding()]
param()
begin { }
process { }
end { }
dispose { }
}
Reference PowerShell/PowerShell#9900 for indication on when the feature will become available. From current team decisions it appears it will likely be merged post-v7 and generally available the following release.
This is all the references to named blocks I could find, and I updated an example or two while I was at it. If I missed anything, please let me know.
/cc TylerLeonhardt
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
TylerLeonhardt reacted with thumbs up emoji
TylerLeonhardt reacted with hooray emoji
TylerLeonhardt reacted with rocket emoji
All reactions
-
👍
1 reaction
-
🎉
1 reaction
-
🚀
1 reaction
Add dispose{} named block keyword to language files.
Yay, editor highlighting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is all it takes at this time.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM awaiting merge in PowerShell repo
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
vexx32 reacted with heart emoji
|
Thanks for this! Closing as the alternative clean block was implemented and merged instead of dispose.
|
vexx32 reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
2 more reviewers
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.