GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add syntax highlighting for 'clean {}' block by daxian-dbw · Pull Request #208 · PowerShell/EditorSyntax

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Jul 16, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a follow-up PR of #186, because of the renaming of the new named block.

function Get-Foo {
    [CmdletBinding()]
    param()

    begin { }
    process { }
    end { }
    clean { }
}

Reference PowerShell/PowerShell#15177 for indication on when the feature will become available.
PowerShell/PowerShell#15177 did some design changes based on the original PR PowerShell/PowerShell#9900

/cc Andy Jordan (@andschwa) and Rain Sallow (/u/ta11ow) (@vexx32)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vexx32, andyleejordan, and 0xfeeddeadbeef reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@daxian-dbw
Add syntax highlighting for 'clean {}'
4d64a84
@andyleejordan

Andy Jordan (andyleejordan) commented Jul 20, 2021

Copy link
Copy Markdown
Member

Thanks for this Dongbo Wang (@daxian-dbw)! We'll get it merged closer to the timeline of the feature itself being merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Oct 14, 2021
Add clean block to script block as a peer to begin, process, and end to allow easy resource cleanup PowerShell/PowerShell#15177
Merged
15 tasks done
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Oct 14, 2021

Copy link
Copy Markdown
Member Author

Andy Jordan (@andschwa) PowerShell/PowerShell#15177 has been merged, so can you please review this PR and maybe merge it as well?
andyleejordan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andyleejordan
Andy Jordan (andyleejordan) approved these changes Oct 14, 2021
View reviewed changes

@andyleejordan Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yeah! I see no reason not to merge this now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@andyleejordan
Andy Jordan (andyleejordan) merged commit 742f0b5 into PowerShell:master Oct 14, 2021
@andyleejordan Andy Jordan (andyleejordan) mentioned this pull request Oct 14, 2021
Add recognition for Dispose{} named function block #186
Closed
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the block-name branch October 14, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@daxian-dbw @andyleejordan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.