GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WIP: get Linux build to upload build artifacts by JamesWTruher · Pull Request #1293 · PowerShell/PSScriptAnalyzer

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

PR Summary

get Linux build to upload build artifacts
Add additional output to assist with debugging if there is a problem

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
James Truher (JamesWTruher) added 8 commits July 19, 2019 12:32
@JamesWTruher
Add additional output to assist with debugging if there is a problem
f60bf88
@JamesWTruher
Add more debugging to build.psm1
c1db4c2
@JamesWTruher
additional debug output v3
f7dc29a
@JamesWTruher
v4 debugging
7bd18a3
@JamesWTruher
v5 debugging
4b5eb3a
@JamesWTruher
v6 debugging
2962958
@JamesWTruher
v7 debugging
7f29893
@JamesWTruher
v8 debug
02d419f
bergmeister
Christoph Bergmeister (bergmeister) reviewed Jul 26, 2019
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some minor changes need to be done before the merge. Thanks for investigating and fixing it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread PSCompatibilityCollector/build.ps1
else {
$dotnet = "dotnet"
}
& $dotnet publish -f $Framework -c $Configuration

@bergmeister Christoph Bergmeister (bergmeister) Jul 26, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this the fix for the premature build abortion

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tests/Engine/CustomizedRule.tests.ps1
#if ($IsLinux)
#{
# $expectedNumRules = 4
#}

@bergmeister Christoph Bergmeister (bergmeister) Jul 26, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just delete those commented out code lines now that it works without a special case (not sure why, I guess some upstream dependency received a fix)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread appveyor.yml
# PowerShellEdition: WindowsPowerShell
# - APPVEYOR_BUILD_WORKER_IMAGE: WMF 4
# PowerShellEdition: WindowsPowerShell
# PSVersion: 4

@bergmeister Christoph Bergmeister (bergmeister) Jul 26, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please uncomment again before the merge

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread build.psm1
if ( $LASTEXITCODE -ne 0 ) {
$buildOutput | Write-Verbose -Verbose
throw "$buildOutput"
}

@bergmeister Christoph Bergmeister (bergmeister) Jul 26, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation of closing brace is 1 level too much

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bergmeister
Christoph Bergmeister (bergmeister) reviewed Jul 26, 2019
View reviewed changes
Comment thread tools/appveyor.psm1
Write-Verbose -Verbose "bootstrap complete: $(get-date)"
}
catch {
Write-Warning "error in invocation of build.ps1 from Invoke-AppVeyorInstall"

@bergmeister Christoph Bergmeister (bergmeister) Jul 26, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why catch the error and not let it error out?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Aug 10, 2019
AppVeyor Ubutnu Build Faling - Potential Fix #1306
Closed
@bergmeister

Christoph Bergmeister (bergmeister) commented Aug 22, 2019

Copy link
Copy Markdown
Collaborator

Close and re-open to retrigger CI to check this still works
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) closed this Aug 22, 2019
@bergmeister Christoph Bergmeister (bergmeister) reopened this Aug 22, 2019
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Aug 22, 2019
Fix Ubuntu Appveyor build #1320
Merged
5 tasks done
@bergmeister

Christoph Bergmeister (bergmeister) commented Aug 27, 2019

Copy link
Copy Markdown
Collaborator

James Truher (@JamesWTruher) Shall we close this one as #1320 has the essential bits of this PR (fixing the build and uploading the tests work now again), the only thing that this PR would add are the additional verbose logs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister

Christoph Bergmeister (bergmeister) commented Aug 30, 2019

Copy link
Copy Markdown
Collaborator

Although the recently merged PR fixed the Ubuntu build it seems that it has lasted only a few days as AppVeyor updated their image with breaking changes again, will close and re-open to see if this branch is any different
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) closed this Aug 30, 2019
@bergmeister Christoph Bergmeister (bergmeister) reopened this Aug 30, 2019
@rjmholt
Rob Holt (rjmholt) marked this pull request as draft April 21, 2021 21:13
@andyleejordan Andy Jordan (andyleejordan) closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister left review comments
Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JamesWTruher @bergmeister @andyleejordan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.