GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Ubuntu Appveyor build by bergmeister · Pull Request #1320 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Aug 22, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

A minimalized and ready to be merged version of PR #1293 Thanks to James Truher (@JamesWTruher) for the hard work of finding the issue/solution. Tests get now also correctly registered (probably something that Appveyor fixed)

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • [NA] Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister (bergmeister) added 5 commits August 22, 2019 20:54
@bergmeister
try fix appveyor ubuntu build
1491d4c
@bergmeister
temporarily enable only ubuntu
4c360ad
@bergmeister
remove redundant linux customisation
225da89
@bergmeister
fix compatibility analyser build
9a5c636
@bergmeister
final tweak to make it ready for PR
8224843
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Aug 22, 2019
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) August 22, 2019 20:08
rjmholt
Rob Holt (rjmholt) reviewed Aug 23, 2019
View reviewed changes
Comment thread tools/appveyor.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
rjmholt
Rob Holt (rjmholt) approved these changes Aug 23, 2019
View reviewed changes
@bergmeister @rjmholt
Update tools/appveyor.psm1
59d1e6f 
Co-Authored-By: Robert Holt <[email protected]>
JamesWTruher
James Truher (JamesWTruher) approved these changes Aug 27, 2019
View reviewed changes
@JamesWTruher
James Truher (JamesWTruher) merged commit 5cd3065 into PowerShell:master Aug 27, 2019
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Aug 27, 2019
WIP: get Linux build to upload build artifacts #1293
Closed
4 of 6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister @rjmholt @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.