GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Increase maximum runspace pool size in flaky test by bergmeister · Pull Request #1358 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Oct 26, 2019

Copy link
Copy Markdown
Collaborator

PR Summary

Increase maximum number over time until we find a stable upper limit. It turns out one cannot do a straightforward calculation of runspaces (either due to complexity or garbage collection)
An example build failure with 14 runspaces is here: https://ci.appveyor.com/project/PowerShell/psscriptanalyzer/builds/28399656/job/8d7spi13o6kekjaw?fullLog=true

cc Thomas Rayner (@thomasrayner) for visiblity

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
Increase maximum runspace pool size in flaky test
3fc353a
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Oct 26, 2019
@bergmeister Christoph Bergmeister (bergmeister) assigned James Truher (JamesWTruher) Oct 26, 2019
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Oct 27, 2019
Use Where-Object instead of alias in buildmodule.tests.ps1 #1360
Merged
5 of 6 tasks
@bergmeister

Christoph Bergmeister (bergmeister) commented Nov 11, 2019

Copy link
Copy Markdown
Collaborator Author

re-trigger ci
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) closed this Nov 11, 2019
@bergmeister Christoph Bergmeister (bergmeister) reopened this Nov 11, 2019
Christoph Bergmeister
Merge branch 'master' into bergmeister-patch-2
58cca79
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from James Truher (JamesWTruher) January 2, 2020 22:17
JamesWTruher
James Truher (JamesWTruher) approved these changes Jan 16, 2020
View reviewed changes
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 86c48b4 into master Jan 16, 2020
@bergmeister
Christoph Bergmeister (bergmeister) deleted the bergmeister-patch-2 branch February 9, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JamesWTruher James Truher (JamesWTruher)

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.