GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use Where-Object instead of alias in buildmodule.tests.ps1 by kvprasoon · Pull Request #1360 · PowerShell/PSScriptAnalyzer

Conversation

@kvprasoon

@kvprasoon PRASOON KARUNAN V (kvprasoon) commented Oct 26, 2019

Copy link
Copy Markdown
Contributor

PR Summary

Use Where-Object instead of ? in BuildModule.tests.ps1

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kvprasoon
use Where-Object instead of alias
9691527
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Oct 26, 2019
View reviewed changes
@kvprasoon

PRASOON KARUNAN V (kvprasoon) commented Oct 27, 2019

Copy link
Copy Markdown
Contributor Author

Christoph Bergmeister (@bergmeister) any idea on CI failures ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister

Christoph Bergmeister (bergmeister) commented Oct 27, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

The first failure is a relatively new, but known sporadic failure, for which PR #1358 has been opened.
The other 4 failures started to happen only this week without a code change in master and are probably due to a breaking change in an AppVeyor image update.
Concluding, don't worry about them, they are unrelated and not blocking your PR from being merged but ideally, we want to have them fixed in master first before merging more PRs.
kvprasoon reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
add whitespace after pipe
d8a4d22
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 18d0f03 into PowerShell:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kvprasoon @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.