GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Correct casing of parameters as well in PSUseCorrectCasing formatter rule by bergmeister · Pull Request #1391 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Jan 4, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

Correct casing of parameters as well in PSUseCorrectCasing formatter rule.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister added 2 commits January 4, 2020 12:01
Christoph Bergmeister
Correct casing of parameters. TODO: diagnostic messages
df751f8
Christoph Bergmeister
Update message strings
4686bb9
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Formatter label Jan 4, 2020
Christoph Bergmeister
update docs
d16eba5
JamesWTruher
James Truher (JamesWTruher) approved these changes Jan 16, 2020
View reviewed changes
Christoph Bergmeister
Merge branch 'master' of https://github.com/powershell/psscriptanalyzer…
fee5933 
… into correctParameterCasing

# Conflicts:
#	Rules/Strings.resx
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 16, 2020

Copy link
Copy Markdown
Collaborator Author

Failures are just the sporadic Ubuntu ones, which are known, merging
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
Christoph Bergmeister (bergmeister) merged commit f3f0a07 into PowerShell:master Jan 16, 2020
Christoph Bergmeister (bergmeister) added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Feb 7, 2020
@bergmeister
Fix recently introduced bug (PR PowerShell#1391) for UseCorrectCasing
8690db2
Christoph Bergmeister (bergmeister) added a commit that referenced this pull request Feb 7, 2020
@bergmeister
Fix recently introduced bug (PR #1391) for UseCorrectCasing (#1408)
f24af8d
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Feb 9, 2020
Set default of CheckParameter configuration setting to false when settings are not present #1411
Merged
5 of 6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.