GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixes #1720 - move rule docs and update tests by sdwheeler · Pull Request #1724 · PowerShell/PSScriptAnalyzer

Conversation

@sdwheeler

@sdwheeler Sean Wheeler (sdwheeler) commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

PR Summary

PR Checklist

  • Moved ./RulesDocumentation to ./docs/Rules

  • Moved ./docs/markdown to ./docs/Cmdlets

  • Update Pester test for documentation

  • PR has a meaningful title

    • Use the present tense and imperative mood when describing your changes

  • Summarized changes

  • Change is not breaking

  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header

  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation

  • This PR is ready to merge and is not Work in Progress.

    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sdwheeler
Fixes PowerShell#1720 - move rule docs and update tests
1e81003
@rjmholt

Rob Holt (rjmholt) commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

Looks like platyPS invocations in the build script also need to be updated
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sdwheeler

Sean Wheeler (sdwheeler) commented Oct 5, 2021

Copy link
Copy Markdown
Contributor Author

Rob Holt (@rjmholt) OK, I missed that. Will update.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sdwheeler
Update build for new location of cmdlet docs
e9b5b32
@sdwheeler

Sean Wheeler (sdwheeler) commented Oct 5, 2021

Copy link
Copy Markdown
Contributor Author

Rob Holt (@rjmholt) Fixed the build script.
rjmholt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sdwheeler
Sean Wheeler (sdwheeler) enabled auto-merge (squash) October 5, 2021 21:58
rjmholt
Rob Holt (rjmholt) approved these changes Oct 5, 2021
View reviewed changes
@sdwheeler
Sean Wheeler (sdwheeler) merged commit 359f98f into PowerShell:master Oct 5, 2021
@bgold09 Brian Golden (bgold09) mentioned this pull request Oct 7, 2021
Fix base URI for PSScriptAnalyzer rule documentation PowerShell/vscode-powershell#3608
Merged
4 tasks done
@andyleejordan

Andy Jordan (andyleejordan) commented Oct 8, 2021

Copy link
Copy Markdown
Member

Hi, Rob Holt (@rjmholt) and Sean Wheeler (@sdwheeler) this PR caused a regression in the VS Code extension because the URL used to find the documentation was changed. Heads up to coordinate changes like this in the future. I'm pushing a new release today with the bug-fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt Rob Holt (rjmholt) mentioned this pull request Oct 14, 2021
Fix broken links to old .md files, set correct root directory for Get-RuleDocumentationPath function #1730
Closed
6 tasks done
@sdwheeler
Sean Wheeler (sdwheeler) deleted the sdw-i1720 branch May 23, 2022 18:29
@rmuraix Ryota Murai (rmuraix) mentioned this pull request Sep 22, 2022
Fix #6 - Fix bad link references microsoft/psscriptanalyzer-action#8
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sdwheeler @rjmholt @andyleejordan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.