GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix base URI for PSScriptAnalyzer rule documentation by bgold09 · Pull Request #3608 · PowerShell/vscode-powershell

Conversation

@bgold09

@bgold09 Brian Golden (bgold09) commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

PR Summary

PR PowerShell/PSScriptAnalyzer#1724 moved all documentation to a new
directory in the repo. Therefore when a rule violation is detected in
the editor and a user uses the code action to navigate to the rule's
documentation, they are brought to an invalid URI.

Fixing the base URI to rule documentation in the PSScriptAnalyzer repo.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bgold09
Fix base URI for rule documentation
19ac311
@andyleejordan Andy Jordan (andyleejordan) added Area-Script Analysis Issue-Bug A bug to squash. labels Oct 8, 2021
@andyleejordan Andy Jordan (andyleejordan) changed the title Fix base URI for rule documentation Fix base URI for PSScriptAnalyzer rule documentation Oct 8, 2021
andyleejordan
Andy Jordan (andyleejordan) approved these changes Oct 8, 2021
View reviewed changes

@andyleejordan Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thank you so much!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andyleejordan
Andy Jordan (andyleejordan) enabled auto-merge (squash) October 8, 2021 16:41
@andyleejordan Andy Jordan (andyleejordan) linked an issue Oct 8, 2021 that may be closed by this pull request
PSScriptAnalyzer links from the Problem panel 404. #3609
Closed
4 tasks done
@andyleejordan
Andy Jordan (andyleejordan) merged commit 8f40aa1 into PowerShell:master Oct 8, 2021
@sdwheeler Sean Wheeler (sdwheeler) mentioned this pull request Oct 8, 2021
Update PSScriptAnalyzer rule documentation to docs.microsoft.com #3610
Closed
2 tasks done
@bgold09

Brian Golden (bgold09) commented Oct 8, 2021

Copy link
Copy Markdown
Contributor Author

Andy Jordan (@andschwa) no problem, it was an easy fix 😄
andyleejordan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bgold09
Brian Golden (bgold09) deleted the dev/bgold09/fix/ruleDocumenationUri branch October 8, 2021 18:23
SyfiMeal added a commit to SyfiMeal/vscode-powershell that referenced this pull request Oct 23, 2021
@SyfiMeal
Revert "Fix base URI for rule documentation (PowerShell#3608)"
3fedab9 
This reverts commit 8f40aa1.
@SyfiMeal SyfiMeal mentioned this pull request Oct 23, 2021
Revert "Fix base URI for PSScriptAnalyzer rule documentation" #3632
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area-Script Analysis Issue-Bug A bug to squash.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PSScriptAnalyzer links from the Problem panel 404.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bgold09 @andyleejordan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.