GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Also return suggestion to use PSCredential for AvoidUsingPlainTextForPassword rule by bergmeister · Pull Request #1782 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Mar 28, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #1767 by also adding an option for PSCredential.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
Also return suggestion to use PSCredential for AvoidUsingPlainTextFor…
7724325 
…Password rule
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Rules label Mar 28, 2022
Christoph Bergmeister (bergmeister) added 3 commits March 29, 2022 20:21
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PSScriptAnalyzer…
e946f27 
… into avoidusingplaintextforpassword-multiple-suggestions
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PSScriptAnalyzer…
bd12868 
… into avoidusingplaintextforpassword-multiple-suggestions
@bergmeister
fix tests
30b4bcb
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Mar 30, 2022
Correctly map SuggestedCorrection to MarkerCorrection PowerShell/PowerShellEditorServices#1749
Merged
@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 30, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

PR that fixes the UI bug in the extension, which only displayed one code action: PowerShell/PowerShellEditorServices#1749
StevenBucher98 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Andy Jordan (andyleejordan) added a commit to PowerShell/PowerShellEditorServices that referenced this pull request Mar 31, 2022
@bergmeister @andyleejordan
Correctly map SuggestedCorrection to MarkerCorrection (#1749)
c49fa2a 
With the recent fix in PR #1718, PSES processes now all Correction objects from PSSA but the message specifically was just taken from the last correction here. I did not notice this at first because I thought I had to tweak my rule first to emit two different messages until I realized it was another bug in PSES.

Related: PowerShell/PSScriptAnalyzer#1782

Co-authored-by: Andy Schwartzmeyer <[email protected]>
JamesWTruher
James Truher (JamesWTruher) approved these changes May 10, 2022
View reviewed changes
@bergmeister
Christoph Bergmeister (bergmeister) enabled auto-merge (squash) May 16, 2022 16:56
@bergmeister

Christoph Bergmeister (bergmeister) commented May 16, 2022

Copy link
Copy Markdown
Collaborator Author

James Truher (@JamesWTruher) Can you please help force merge it due to the old checks removed in master that are blocking the merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sdwheeler
Sean Wheeler (sdwheeler) reviewed Jun 6, 2022
View reviewed changes

@sdwheeler Sean Wheeler (sdwheeler) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the severity of this rule be DiagnosticSeverity.Error to match the severity of AvoidUsingConvertToSecureStringWithPlainText?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
floh96 reacted with eyes emoji
All reactions
  • 👀 1 reaction
@bergmeister

Christoph Bergmeister (bergmeister) commented Jun 15, 2022

Copy link
Copy Markdown
Collaborator Author

Should the severity of this rule be DiagnosticSeverity.Error to match the severity of AvoidUsingConvertToSecureStringWithPlainText?

I think existing severities of old rules like this one are very inconsistent but my thinking is that Error should only be set when there would be a runtime problem and the rule is certain on not being a false positive, i.e. a 'must fix'. Therefore I'd rather downgrade severity of AvoidUsingConvertToSecureStringWithPlainText TBH
andyleejordan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 87199e5 into PowerShell:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@sdwheeler Sean Wheeler (sdwheeler) sdwheeler left review comments
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UsePSCredentialType : on a variable $credential the quickfix proposed is [securestring] instead of [PsCredential]

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister @JamesWTruher @sdwheeler
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.