GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PSAvoidUsingPositionalParameters: Do not warn on AZ CLI by bergmeister · Pull Request #1846 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Sep 22, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #1845
AZ CLI entrypoint recently changed from a batch file to an az.ps1 'script' in latest version 2.40.0, which just passed $args arguments as-is to python so it is still a CLI and not a script with parameters.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
PSAvoidUsingPositionalParameters: Do not warn on AZ CLI
e2674c3
@bergmeister Christoph Bergmeister (bergmeister) added this to the 1.21 milestone Sep 22, 2022
@bergmeister

Christoph Bergmeister (bergmeister) commented Sep 22, 2022

Copy link
Copy Markdown
Collaborator Author

After an internal review we decided that we should not have it in code but as configuration but can still exclude az by default.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Christoph Bergmeister (bergmeister) added 2 commits September 24, 2022 19:56
@bergmeister
Add CommandAllowList configuration and make it case insensitive
e9dbf52
@bergmeister
fix failing test on Linux as az is not a script on linux and make tes…
3a97de8 
…t not depend on AZ CLI
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Rules label Sep 24, 2022
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from James Truher (JamesWTruher) September 24, 2022 19:52
JamesWTruher
James Truher (JamesWTruher) approved these changes Sep 27, 2022
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks really good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bergmeister reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@JamesWTruher
James Truher (JamesWTruher) merged commit e88b4c4 into PowerShell:master Sep 27, 2022
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Oct 24, 2022
AvoidUsingPositionalParameter: Check if command has parameters to avoid having az in default CommandAllowList #1850
Merged
5 of 6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Rules

Projects

None yet

Milestone

1.21

Development

Successfully merging this pull request may close these issues.

PSAvoidUsingPositionalParameters reports issue with az command when version 2.40.0 of az cli is installed

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.