GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — AvoidUsingPositionalParameter: Check if command has parameters to avoid having az in default CommandAllowList by bergmeister · Pull Request #1850 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Oct 24, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

This is an enhancement to CommandAllowList introduced in #1846
To avoid having az as the default in it, return now the discovered command and inspect whether it has parameters. If not, which is the case for the az CLI, then do not continue analyzing usage of that command.
Also, az has backed out their change since then so with latest version of az, we don't need it as default allow-list anyway.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
AvoidUsingPositionalParameter : Check if command has parameters
9b98322
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Rules label Oct 24, 2022
Christoph Bergmeister (bergmeister) added 2 commits October 24, 2022 12:24
@bergmeister
fix syntax
5e9cbed
@bergmeister
remove unneeded test
8127a16
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 25, 2022 16:43
@bergmeister
Merge branch 'master' into AvoidUsingPositionalParameter-CheckForParams
73d3401
@JamesWTruher

James Truher (JamesWTruher) commented Jan 16, 2024

Copy link
Copy Markdown
Contributor

Christoph Bergmeister (@bergmeister) should we have any validation for this new behavior? Not about removing "az", but rather the command having no parameters
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JamesWTruher
James Truher (JamesWTruher) reviewed Jan 18, 2024
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 question

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Rules/AvoidPositionalParameters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
Update Rules/AvoidPositionalParameters.cs
f7e55ee
@bergmeister
Christoph Bergmeister (bergmeister) enabled auto-merge (squash) February 12, 2024 18:10
JamesWTruher
James Truher (JamesWTruher) approved these changes Feb 13, 2024
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
Christoph Bergmeister (bergmeister) merged commit df3551e into PowerShell:master Feb 13, 2024
This was referenced Mar 16, 2024
Update PSScriptAnalyzer to v1.22.0 ForNeVeR/intellij-powershell-fork#1
Closed
Update PSScriptAnalyzer to v1.22.0 intellij-powershell/intellij-powershell#244
Merged
Update PowerShellEditorServices to v3.18.1 and PSScriptAnalyzer to v1.22.0 ForNeVeR/intellij-powershell-fork#2
Closed
Rob Holt (rjmholt) added a commit to rjmholt/PSScriptAnalyzer that referenced this pull request Feb 23, 2026
@rjmholt @cursoragent
Port remaining upstream bug fixes for two rules
edd5247 
UseDeclaredVarsMoreThanAssignments (PowerShell#2013): skip scope-qualified
variable references ($global:, $script:, drive-qualified) when
checking for uses of local variables, preventing false negatives.

AvoidPositionalParameters (PowerShell#1850): skip commands that have no
parameters in the database (e.g. native CLI tools like az).

Co-authored-by: Cursor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.