GeezerVison

I don't see where I should add a test like that.

There seems to be no such test for other presets, only the specific settings seems to be tested.

Also, there are some of the tests that make no sense. Like:

No comments are involved in those tests.

Idea: Should be create a new test file that has all the samble codes from:

PoshCode/PowerShellPracticeAndStyle#177

And just say that they are the expected output from the various presets?

I added some suggestions for tests now Christoph Bergmeister (@bergmeister). 😊

Hmm, may these tests have found a bug in the Stroustrup preset? No, two bugs?

1. The opening curly bracket after function definition is not on a new line.
2. Opening paranthese after param should be on the same line.

PS > $Allman = @'
enum Color
{
    Black,
    White
}

function Test-Code
{
    [CmdletBinding()]
    param
    (
        [int] $ParameterOne
    )
    end
    {
        if (10 -gt $ParameterOne)
        {
            "Greater"
        }
        else
        {
            "Lesser"
        }
    }
}
'@

PS > Invoke-Formatter -ScriptDefinition $Allman -Settings 'CodeFormattingStroustrup'
enum Color {
    Black,
    White
}

function Test-Code {
    [CmdletBinding()]
    param
    (
        [int] $ParameterOne
    )
    end {
        if (10 -gt $ParameterOne) {
            "Greater"
        }
        else {
            "Lesser"
        }
    }
}

Edit: These are probably shortcomings with PSSA?

Happy to add it but can you please add a test that specifically tests the OTPS part of else being on new line? Liam Peters (@liamjpeters) Are you happy with those properties since you added new ones and potentially other ones in pending PRs? Or would we need to take a note to add certain properties later here?

All good with me 😊. I should look over the settings presets once #2132 is merged, to add in the enum alignment, but that can wait. Good reminder, thanks!

Olav Rønnestad Birkeland (@o-l-a-v) - Thanks for the new tests 👍

If I understand it correctly, PSSA code formatting only handles curly brackets, thus there will be no difference between Stroustrup and this new proposed preset. As the new test file shows, PSSA does not touch param(), or differentiates on function {} vs. if {} else {}.

If I'm not missing anything here I don't think this proposal makes sense anymore.

What do you guys think we should do? Remove the new preset, keep the closing brackets tests, remove or move to disabled the new test file I made for preset tests?

Olav Rønnestad Birkeland (@o-l-a-v) can you please resolve merge conflict and review latest copilot review? what is the reason this PR is back in draft and not ready?

Olav Rønnestad Birkeland (@o-l-a-v) can you please resolve merge conflict and review latest copilot review? what is the reason this PR is back in draft and not ready?

#2158 (comment)

Olav Rønnestad Birkeland (Olav Rønnestad Birkeland (@o-l-a-v)) can you please resolve merge conflict and review latest copilot review? what is the reason this PR is back in draft and not ready?

#2158 (comment)

so formatting rules deal with tokens so it doesn't just look at braces but as it's derived from the AST, some things like param() don't show in the AST. the AST will always be the limitation as PSSA relies on PowerShell's parser