GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(tests): added closing bracket test for formatting presets by o-l-a-v · Pull Request #2161 · PowerShell/PSScriptAnalyzer

Conversation

@o-l-a-v

@o-l-a-v Olav Rønnestad Birkeland (o-l-a-v) commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Since #2158 is blocked due to PSScriptAnalyzer formatting limitations #2045 (comment) I thought I could at least add the relevant tests I created in that PR, without the proposed new preset OTPS.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@o-l-a-v
feat(tests): added closing bracket test for formatting presets
06c7c72
Copilot AI review requested due to automatic review settings March 7, 2026 12:38
Copilot started reviewing on behalf of Olav Rønnestad Birkeland (o-l-a-v) March 7, 2026 12:39
View session
Copilot AI reviewed Mar 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds regression-style tests for Invoke-Formatter behavior around if/else close-brace placement across formatting presets, to preserve expected formatting semantics while broader preset work remains blocked upstream.

Changes:

  • Adds new Pester context validating if/else formatting output for CodeFormattingAllman, CodeFormattingOTBS, and CodeFormattingStroustrup.
  • Introduces canonical input/expected script definitions for the three brace styles and asserts formatter round-trips between them.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tests/Rules/PlaceCloseBrace.tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tests/Rules/PlaceCloseBrace.tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@o-l-a-v
Update Tests/Rules/PlaceCloseBrace.tests.ps1
6d09139 
Co-authored-by: Copilot <[email protected]>
@o-l-a-v
Olav Rønnestad Birkeland (o-l-a-v) requested review from a team and Christoph Bergmeister (bergmeister) as code owners March 7, 2026 12:47
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Mar 9, 2026
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to have more tests :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
o-l-a-v reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from Andy Jordan (andyleejordan) March 18, 2026 19:13
@andyleejordan
Andy Jordan (andyleejordan) merged commit ac48fad into PowerShell:main Mar 18, 2026
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@o-l-a-v
Olav Rønnestad Birkeland (o-l-a-v) deleted the feat/add-test-for-formatting-presets-square-bracket-handling branch March 19, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
@andyleejordan Andy Jordan (andyleejordan) Awaiting requested review from andyleejordan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@o-l-a-v @bergmeister @andyleejordan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.