GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Encoding Parameter for Tee-Object by Peter-Schneider · Pull Request #12135 · PowerShell/PowerShell

Conversation

@Peter-Schneider

@Peter-Schneider Peter Schneider (Peter-Schneider) commented Mar 16, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Adds an Encoding parameter to the Tee-Object cmdlet (See issue #11104)

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: Add documentation for Tee-Object -Encoding Parameter  MicrosoftDocs/PowerShell-Docs#5612
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost ghost assigned Ilya (iSazonov) Mar 16, 2020
vexx32
Rain Sallow (/u/ta11ow) (vexx32) suggested changes Mar 16, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
@vexx32

Rain Sallow (/u/ta11ow) (vexx32) commented Mar 16, 2020

Copy link
Copy Markdown
Collaborator

Ha, you beat me to it. 😁
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vexx32
Rain Sallow (/u/ta11ow) (vexx32) approved these changes Mar 16, 2020
View reviewed changes
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
christian7877
christian7877 suggested changes Mar 16, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
@Peter-Schneider

Peter Schneider (Peter-Schneider) commented Mar 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Rain Sallow (/u/ta11ow) (@vexx32) Thank you anyway.. ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 17, 2020
@iSazonov

Ilya (iSazonov) commented Mar 17, 2020

Copy link
Copy Markdown
Collaborator

Peter Schneider (@Peter-Schneider) Please add tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 17, 2020
@iSazonov Ilya (iSazonov) added this to the 7.1.0-preview.1 milestone Mar 17, 2020
@iSazonov Ilya (iSazonov) added the Documentation Needed in this repo Documentation is needed in this repo label Mar 17, 2020
iSazonov
Ilya (iSazonov) reviewed Mar 18, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) reviewed Mar 18, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) reviewed Mar 18, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) reviewed Mar 19, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Mar 20, 2020

Copy link
Copy Markdown
Collaborator

Peter Schneider (@Peter-Schneider) Please open new issue in PowerShell-Docs repo for the new parameter and add reference in the PR description.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Peter-Schneider Peter Schneider (Peter-Schneider) mentioned this pull request Mar 20, 2020
Add documentation for Tee-Object -Encoding Parameter MicrosoftDocs/PowerShell-Docs#5612
Closed
1 of 11 tasks
@iSazonov

Ilya (iSazonov) commented Mar 20, 2020

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) Travis Plunk (@TravisEz13) Could you please look CI failures? It seems it is not the PR related.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Mar 20, 2020

Copy link
Copy Markdown
Member

Ilya (@iSazonov) The windows failure definitely seem related to this branch. Perhaps a rebase is needed.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Mar 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Peter Schneider (@Peter-Schneider) Please rebase. You will be switched to new .Net version - 5.0 Preview1, so you should install it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) reviewed Mar 21, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Peter-Schneider
Use Pester special drive for temp files and remove testfile in Before…
b56f7c0 
…All Pester block
iSazonov
Ilya (iSazonov) reviewed Mar 21, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Peter Schneider (Peter-Schneider) and others added 2 commits March 21, 2020 17:14
@Peter-Schneider
Delte testfile in BeforeEach Pester block
b08faa4
@Peter-Schneider @iSazonov
Fix CI
3af62f4 
Co-Authored-By: Ilya <[email protected]>
iSazonov
Ilya (iSazonov) reviewed Mar 22, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Peter-Schneider
Changed testValue to ф
bace4cb
@TravisEz13 Travis Plunk (TravisEz13) removed the Review - Needed The PR is being reviewed label Jun 2, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 10, 2020
@ghost

Deleted user (ghost) commented Jun 10, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Jun 11, 2020

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13) Steve Lee (@SteveL-MSFT) Could you please review the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 11, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 18, 2020
@ghost

Deleted user (ghost) commented Jun 18, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) removed this from the 7.1.0-preview.4 milestone Jun 29, 2020
@iSazonov Ilya (iSazonov) closed this Jul 22, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 22, 2020
@iSazonov Ilya (iSazonov) reopened this Jul 22, 2020
@iSazonov

Ilya (iSazonov) commented Jul 22, 2020

Copy link
Copy Markdown
Collaborator

Reopen to update CIs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost added the Review - Needed The PR is being reviewed label Jul 30, 2020
@ghost

Deleted user (ghost) commented Jul 30, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) Can we merge?
Peter-Schneider reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 16, 2021
@ghost

Deleted user (ghost) commented Jan 16, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jul 21, 2021

Copy link
Copy Markdown
Member

Ilya (@iSazonov) I think this is good to go. thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 21, 2021
@SteveL-MSFT Steve Lee (SteveL-MSFT) closed this Jul 21, 2021
@SteveL-MSFT Steve Lee (SteveL-MSFT) reopened this Jul 21, 2021
@iSazonov
Ilya (iSazonov) merged commit de5dc63 into PowerShell:master Jul 22, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.8 milestone Jul 22, 2021
@iSazonov

Ilya (iSazonov) commented Jul 22, 2021

Copy link
Copy Markdown
Collaborator

Peter Schneider (@Peter-Schneider) Thanks for your contribution!
SteveL-MSFT reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Peter-Schneider

Peter Schneider (Peter-Schneider) commented Jul 22, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for merging! 🥳
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

Deleted user (ghost) commented Aug 23, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

Deleted user (ghost) commented Sep 28, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@Peter-Schneider
Encoding Parameter for Tee-Object (PowerShell#12135)
51f63e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
+2 more reviewers
@christian7877 christian7877 christian7877 requested changes
@vexx32 Rain Sallow (/u/ta11ow) (vexx32) vexx32 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.8

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Peter-Schneider @vexx32 @iSazonov @TravisEz13 @SteveL-MSFT @christian7877 @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.