GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Remove dependency on DNS for `Test-Connection` tests on macOS by rjmholt · Pull Request #12943 · PowerShell/PowerShell Conversation
|
|
From CI, it seems that solving the setup issue kicks the can down to a test failure instead where |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
From the CI, it looks like |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Rob Holt (@rjmholt) the cmdlet uses the system.net.dns APIs internally quite a bit, so I'd imagine if those APIs themselves are failing it'll most likely fall apart in at least a couple of cases. Definitely seems like something changed that the .NET Core folks will need to take a look at... 😕 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
| if (-not $?) | ||
| { | ||
| Get-Error | Out-String | Write-Host |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to use -Because with the first Should test to have this in the test log?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ok the latest change proves that this is a CI configuration issue rather than a .NET issue |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Reopening to run something in CI |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Steve Lee (@SteveL-MSFT) Please update your review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| $gatewayAddress = GetGatewayAddress | ||
| $publicHostAddress = GetExternalHostAddress -HostName $hostName | ||
|
|
||
| $testAddress = if ($publicHostAddress) { $publicHostAddress } else { $gatewayAddress } |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, but could have used the null conditional assignment operator here
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
This needs to port back to 6.2 -- deliberately removed new operators in most recent commit
Sorry, something went wrong.
There was an error while loading. Please reload this page.
said review was not blocking
Test-Connection tests on macOS
|
🎉 Handy links: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🎉 Handy links: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Test-Connection test setup fails on macOS due to DNS issue
There was an error while loading. Please reload this page.